Python recursive function to list all files of a system

Question

0.00/5 (No votes)

See more:

Hello,
I'm writing a program using python on ubuntu 18.04.
The goal of this program is to list all files on the machine in every directory.
I'm using a for loop and recursive programming to achieve this goal.
I write the code below:

Python

def listDirectory(RootPath):
    os.chdir(RootPath)

    print(
        '\n\033[31mCurrently at \033[37m'+
        os.getcwd())

    currentpaths = os.listdir()

    pathList = [RootPath,currentpaths]        
    print('\n\033[32m pathList: \033[37m')
    print(pathList)
    AllPaths.append(pathList)
    
    for path in currentpaths:
        # if the path is a directory crawl it
        # if the path is not a directory go for the next item
        try:
            listDirectory(path)
        except:
            pass

the problem is that...

It goes true the first directory that it sees.
But it doesn't go back for the next directory.
It doesn't recur as I'm expecting.
So it gives me only three pathLists which are the first possible routs it finds.

given the RootPath of

Python

it just goes these Directories

Python

/lib

Python

/lib/hdparm

It doesn't return other addresses, and ends very quickly.

In advance I thank you for your time.

What I have tried:

I'm looking for the problem in my recursive algorithm.

Posted 8-Jul-20 0:56am

m.r.m.40

Updated 8-Jul-20 1:59am

Add a Solution

Comments

Maciej Los 8-Jul-20 7:26am

Check this: Recursive sub folder search and return files in a list python - Stack Overflow[^]

3 solutions

Solution 1

If your code doesn't work - and that happens a lot, even when you have experience - you need to learn to find out why yourself, so you can fix it. Out telling you what it wrong doesn't teach you anything about how to avoid making mistakes in future.

So, it's going to be up to you.
Fortunately, you have a tool available to you which will help you find out what is going on: the debugger. How you use it depends on your compiler system, but a quick Google for the name of your IDE and "debugger" should give you the info you need.
Learn to use it - it's the most powerful tool in your box, and you will probably spend more time using it than the editor - we all do!

Put a breakpoint on the first line in the function, and run your code through the debugger. Then look at your code, and at your data and work out what should happen manually. Then single step each line checking that what you expected to happen is exactly what did. When it isn't, that's when you have a problem, and you can back-track (or run it again and look more closely) to find out why.

Sorry, but we can't do that for you - time for you to learn a new (and very, very useful) skill: debugging!

Posted 8-Jul-20 1:45am

OriginalGriff

Comments

m.r.m.40 8-Jul-20 9:28am

You're right. Thank you. :)
Was the last line necessary? :D

Solution 2

Quote:
I'm looking for the problem in my recursive algorithm.

Watching your code performing is an incredible way to learn how the code works, or don't. The tools of choice is the debugger.
-----
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

27.3. pdb — The Python Debugger — Python 3.6.1 documentation[^]
Debugging in Python | Python Conquers The Universe[^]
pdb – Interactive Debugger - Python Module of the Week[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Posted 8-Jul-20 1:47am

Patrice T

Updated 8-Jul-20 1:55am

v2

Comments

m.r.m.40 8-Jul-20 9:29am

:D :D
OK! I got it.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Luc Pattyn · Accepted Answer · 2020-07-08T01:59:00

Solution 3

The recursive function should not return with your system in a different state, everything should be as it was before. Where do you undo chdir?

Posted 8-Jul-20 1:59am

Luc Pattyn

Updated 8-Jul-20 2:08am

v2

Comments

Richard MacCutchan 8-Jul-20 9:22am

Well spotted.

m.r.m.40 8-Jul-20 9:30am

Yes. Thats the answer.
Thank you.