How to prevent SQL inject for direct SQL commands in ASP.NET for oracle database

Question

1.00/5 (1 vote)

See more:

I am getting always different select commands from ui through textbox.
Ex: string queries = "select name from employe; select id from dept";

internal logic

C#

for (int i=0; i < queries.Length; i++)
{
    OracleCommand cmd = new OracleCommand(queries[i].ToString(), con);
    OracleAdapter oda = new OracleDataAdapter(cmd);
    oda.fill(ds,queries[i]);
}

It's working fine but while checking in that checkmark getting sql injection issue.
Could you please assist on this how to fix the type of scenario.

note: is no scope using storeprocedure here.

What I have tried:

C#

for (int i=0; i < queries.Length; i++)
{
    racleCommand cmd=new OracleCommand(queries[i].ToString(), con);
    OracleAdapter oda= new OracleDAtaAdapter(cmd);
    oda.Fill(ds, queries[i]);
}

Posted 5-Jul-20 21:08pm

DGKumar

Updated 6-Jul-20 2:32am

Richard Deeming

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Simon_Whale · Answer 1 · 2020-07-05T21:32:00

Solution 1

Have a read of this, there is a section on Bind Variables which should get you started

Retrieving and Updating with Oracle Data Provider for .NET[^]

Posted 5-Jul-20 21:32pm

Simon_Whale

Comments

DGKumar 6-Jul-20 4:04am

There are no parameters and where clause in those commands

Simon_Whale 6-Jul-20 4:06am

this is in the "To retrieve data using bind variables:" section under point 6

string sql = "select department_name from departments where department_id = " +
":department_id";
OracleCommand cmd = new OracleCommand(sql, conn);
cmd.CommandType = CommandType.Text;
OracleParameter p_department_id = new OracleParameter();
p_department_id.OracleDbType = OracleDbType.Decimal;
p_department_id.Value = departmentID.Text;
cmd.Parameters.Add(p_department_id);

OracleDataReader dr = cmd.ExecuteReader();
dr.Read();

departments.Items.Add(dr.GetString(0));

Patrice T · Answer 2 · 2020-07-05T22:08:00

Quote:
How to prevent SQL inject for direct SQL commands in ASP.NET for oracle database

As I understand your question, user input is directly the SQL command.
So, by your design, there is no injection to prevent since user type directly commands they want.

C#

Ex: string queries = "select name from employe; drop employe";

SQL injection is only when user type parameters, by allowing user to type directly commands, you are far beyond.

SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]