Inserting file to mssql with dapper

Question

1.00/5 (1 vote)

See more:

Is there a way to insert a file without using parameters?
I am building a string that updates and insert data in several tables at same time, if something fails all changes is rejected.
This is my code:

if (Ordre.Attatchments.Where(x => x.SaveState == false).Count() > 0)
           {
               SqlSaveString.Append("INSERT INTO dbo.SaleAttatchments ([RefUid], [FilePath], [FileName], [FileType], [FileSize],[File], [AttatchInvoice]) VALUES");
               foreach (AttatchmentModel doc in Ordre.Attatchments.Where(x => x.SaveState == false).ToList())
               {
                   if (LineCount > 0) SqlSaveString.Append(",");
                   SqlSaveString.Append($"('{Ordre.SaleUid}', '{doc.FilePath}', '{doc.FileName}', '{doc.FileType}', {doc.FileSize}, {doc.File}, {doc.AttatchInvoice.BoolToTinyInt()})");
               }
               SqlSaveString.Append(";");
           }

What I have tried:

This code works but not what i am looking for.

public void SaveFile(AttatchmentModel parameters, string connectionStringName)
        {
            string connectionString = GetConnectionString(connectionStringName);
            using (IDbConnection connection = new System.Data.SqlClient.SqlConnection(connectionString))
            {
                var sql = "UPDATE dbo.SaleAttatchments SET[File] = @FileData WHERE RefUid = @Id And FileName = @FileName;";
                var dParams = new DynamicParameters();
                dParams.Add("@Id", parameters.RefUID, DbType.String);
                dParams.Add("@FileData", parameters.File, DbType.Binary);
                dParams.Add("@FileName", parameters.FileName, DbType.String);
                connection.Execute(sql, dParams);
            }
        }

Posted 21-Feb-20 5:30am

Member 12983358

Updated 21-Feb-20 6:14am

v2

Add a Solution

Comments

Richard Deeming 21-Feb-20 12:03pm

"without using parameters"

Why? Do you enjoy having your database completely destroyed by every random script-kiddie on the planet?!

NEVER use string concatenation / string.Format / interpolated strings to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2020-02-21T06:15:00

Try:

C#

if (Ordre.Attatchments.Any(x => x.SaveState == false))
{
    string connectionString = GetConnectionString(connectionStringName);
    using (var connection = new System.Data.SqlClient.SqlConnection(connectionString))
    {
        const string sql = "UPDATE dbo.SaleAttatchments SET[File] = @FileData WHERE RefUid = @Id And FileName = @FileName;";
        
        var parameters = new List<DynamicParameters>();
        
        foreach (AttatchmentModel doc in Ordre.Attatchments.Where(x => x.SaveState == false))
        {
            var dParams = new DynamicParameters();
            dParams.Add("@Id", parameters.RefUID, DbType.String);
            dParams.Add("@FileData", parameters.File, DbType.Binary);
            dParams.Add("@FileName", parameters.FileName, DbType.String);
            parameters.Add(dParams);
        }
        
        connection.Execute(sql, parameters);
    }
}

Execute a Command multiple times - Dapper[^]

Alternatively, use a transaction:

C#

if (Ordre.Attatchments.Any(x => x.SaveState == false))
{
    string connectionString = GetConnectionString(connectionStringName);
    using (var connection = new System.Data.SqlClient.SqlConnection(connectionString))
    {
        const string sql = "UPDATE dbo.SaleAttatchments SET[File] = @FileData WHERE RefUid = @Id And FileName = @FileName;";
        
        connection.Open();
        
        using (var transaction = connection.BeginTransaction())
        {
            foreach (AttatchmentModel doc in Ordre.Attatchments.Where(x => x.SaveState == false))
            {
                var dParams = new DynamicParameters();
                dParams.Add("@Id", parameters.RefUID, DbType.String);
                dParams.Add("@FileData", parameters.File, DbType.Binary);
                dParams.Add("@FileName", parameters.FileName, DbType.String);
                connection.Execute(sql, parameters, transaction);
            }
            
            transaction.Commit();
        }
    }
}

Either way, NEVER try to embed your parameter values directly into the SQL query.