I have used following logic for the following code.plz help me correct this code

Question

0.00/5 (No votes)

See more:

Given an integer array of size N. For each element in the array, check whether there exist a smaller element on the next immediate position of the array. If such an element exists, print that element. If there is no smaller element on the immediate next to the element then print -1.

What I have tried:

import java.util.*;
import java.lang.*;
import java.io.*;
class GFG
{
public static void main (String[] args)
{
Scanner sc = new Scanner(System.in);
int t=sc.nextInt();
while(t-->0)
{
List<integer> list = new ArrayList<Integer>(); //Include type (Integer) when declaring a list
while(sc.hasNext())
{
list.add(sc.nextInt());
}

for (int i = 0; i < list.size() - 1; i++) 
{ //note the "- 1" since we are looking ahead 
if (list.get(i).compareTo(list.get(i+1)) > 0) 
{
System.out.print(list.get(i)+" ");
}

else

System.out.print("-1");

}

System.out.println("-1");
}
}
}

Posted 10-Jun-19 8:48am

Member 14492636

Updated 10-Jun-19 22:29pm

Add a Solution

Comments

Dave Kreskowiak 10-Jun-19 15:26pm

And you have a question or a problem you forgot to describe?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2019-06-10T22:29:00

Try:

Java"

import java.util.*;
import java.lang.*;
import java.io.*;
class GFG
{
  public static void main (String[] args)
  {
    Scanner sc = new Scanner(System.in);
    int t=sc.nextInt();
    List<Integer> list = new ArrayList<Integer>(); 
    while(t-- > 0)
    {
      list.add(sc.nextInt());
    }
    for (int i = 0; i < list.size() - 1; i++)
    { //note the "- 1" since we are looking ahead 
      Integer current = list.get(i);
      Integer next = list.get(i+1);
      if (current > next)
      {
        System.out.print(current + " ");
      }
      else
        System.out.print("-1 ");
    }
    System.out.println("-1 ");
  }
}