How to insert new record in my table if not exists? In C# (oracle)

Question

0.00/5 (No votes)

See more:

Hi all
I want to insert a new row into my table if does not exist.
When I write this code for example:
It gives me an error

Quote:
(Oracle.DataAccess.Client.OracleException: 'ORA-00911:)
Characters are not appropriate ')

What I have tried:

C#

using (OracleConnection connection = new OracleConnection(strConnection))
            {
                char quote = '"';
              string strCommand = @"insert into tableinfo( "+quote+"name"+quote+","+quote+"age"+quote+") "+
                "select :name,:age from dual where not exists (select "+quote+"age"+quote+" from tableinfo where "+quote+"age"+quote+" = :age);";
                     
                OracleCommand command = new OracleCommand(strCommand, connection);
                command.Parameters.Add( new OracleParameter("name", "Zoxit"));
                command.Parameters.Add( new OracleParameter("age", 15));

                connection.Open();
                int res = command.ExecuteNonQuery();
//Problem is here(Oracle.DataAccess.Client.OracleException: 'ORA-00911:)
//Characters are not appropriate '
                Console.WriteLine("Result = " + res.ToString());
                Console.ReadKey();

                //insert into tableinfo( "name","age") values(:name,:age)
            }

Posted 3-Oct-18 21:37pm

Member 13999352

Updated 3-Oct-18 22:12pm

CHill60

v2

Add a Solution

2 solutions

Solution 1

The problem is with

string strCommand = @"insert into tableinfo( "+quote+"name"+quote+","+quote+"age"+quote+") "+
                "select :name,:age from dual where not exists (select "+quote+"age"+quote+" from tableinfo where "+quote+"age"+quote+" = :age);";

There is no need for all of those quotes

See this CP article on how to do it properly Oracle Parameterized Queries for the .NET Developer[^]

Posted 3-Oct-18 22:02pm

CHill60

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 13999352 · Accepted Answer · 2018-10-03T22:12:00

Thank you and I solved this problem by using. I removed last semicolon than it worked.
strCommand = @"insert into tableinfo( "+quote+"name"+quote+","+quote+"age"+quote+") "+
                "select :name,:age from dual where not exists (select "+quote+"age"+quote+" from tableinfo where "+quote+"age"+quote+" = :age)";