Onclientclick not working in ASP.NET

Question

0.00/5 (No votes)

See more:

, +

Dear friends,
I have the following JQuery code in asp.net web form:-

function ValidateFields(id) {
$("#Rpt1").find("input[type=text]").each(function () {
if ($.trim($(this).val()) == '') {
alert("At least one textbox is empty");

$(this).focus(); // focus the element
return false;
}
return false;

})
}

and on asp.net button click I have the following code:-
<asp:Button ID="BtnSubmit" runat="server" OnClientClick="if
(ValidateFields('BtnSubmit') == false) return(false);"
OnClick="BtnSubmit_Click" Text="Submit" />

The problem is it always fires the onclick event whether the condition is true or false.

What I have tried:

I tried many things
like
OnClientClick="ValidateFields('BtnSubmit');"
and
OnClientClick="ValidateFields('BtnSubmit'); return false;"

but nothing works.

Please help.

Posted 30-Sep-18 20:21pm

Madhukar Krishna

Updated 30-Sep-18 22:35pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Accepted Answer · 2018-09-30T22:35:00

Your "return false" is making the function inside your "each" method return false, it isn't making the ValidateFields function return false. In the update below I set an isValid variable that is updated by the inner function in "each" and that variable is then returned from ValidateFields.

<script type="text/javascript">
    function ValidateFields(id) {
        var isValid = true;
        $("#Rpt1").find("input[type=text]").each(function () {
            if ($.trim($(this).val()) == '') {
                alert("At least one textbox is empty");


                $(this).focus(); // focus the element
                isValid = false;
            }
        });

        return isValid;
    }

</script>

For multiple control types

function ValidateFields(id) {
    var isValid = true;
    $("#Rpt1").find("input[type=text], input[type=file], .Select1").each(function () {
        var el = $(this);
        switch (this.tagName.toLowerCase()) {
            case "input":
                if (el.val() == '') {
                    if(el.attr('type') == 'text')
                        alert("At least one textbox is empty");
                    else if(el.attr('type') == 'file')
                        alert("Select a file");
                    isValid = false;
                }
                break;
            case "select":
                if (el.val() == '0') {
                    alert("Select a value");
                    isValid = false;
                }
                break;
        }
        if (!isValid) {
            return false;
        }
    });

    return isValid;
}