Why this code is giving output as false even when strings are same?

Question

0.00/5 (No votes)

See more:

, +

I have given two strings the same values but still it's saying the condition is false.

What I have tried:

char s[] = "hello", t[] = "hello";

	std::cout << "s: " << s << std::endl;
	std::cout << "t: " << t << std::endl;

	std::cout << (s == t ? "true" : "false") << std::endl;

Posted 31-Jul-18 6:09am

Member NFOC

Updated 31-Jul-18 7:04am

Add a Solution

2 solutions

Solution 2

This is because is not how string are compared.
in s == t, you are comparing the addresses of both string, and they are always different.

Posted 31-Jul-18 6:22am

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Eric Lynch · Accepted Answer · 2018-07-31T06:21:00

Solution 1

You're comparing the address of the two character arrays, not their contents. Either switch to std::string or use strcmp, see discussion here:

Comparing the values of char arrays in C++ - Stack Overflow[^]

Posted 31-Jul-18 6:21am

Eric Lynch