How can I make this function code more concise rather than using multiple foreach loop ?

Question

0.00/5 (No votes)

See more:

.NET4.5

private void RenumberPreferredSequence(Item record)
        {
            foreach (var itemVendor in record.ItemVendors)
            {
                itemVendor.PreferredSequence = 0;
            }

            foreach (var itemVendor in record.ItemVendors)
            {
                if (itemVendor.PrimaryVendor)
                {
                    itemVendor.PreferredSequence = 1;
                }
            }

            var seq = 2;

            foreach (var itemVendor in record.ItemVendors)
            {
                if (!itemVendor.PrimaryVendor)
                {
                    itemVendor.PreferredSequence = seq;
                    seq = seq + 1;
                }
            }
        }

What I have tried:

Tried using the 1 or 2 foreach loops but unable to achieve what i am expecting.
Like first i should have to make all ItemVendor.PreferredSequence = 0;
Second I should have to make only one

ItemVendor.PreferredSequence = 1 which is a PrimaryVendor
Third i should have to set the sequence on other items in collection

Posted 15-Jun-18 13:07pm

Waqar (Vicky)

Updated 16-Jun-18 9:11am

Add a Solution

2 solutions

Solution 1

Not sure if this is what you want, but think so:

private void RenumberPreferredSequence(Item record)
        {
            var seq = 2;
            foreach (var itemVendor in record.ItemVendors)
            {
                itemVendor.PreferredSequence = 0;
                if (itemVendor.PrimaryVendor)
                {
                    itemVendor.PreferredSequence = seq++;
                }
            }
          }

Posted 15-Jun-18 14:15pm

Clifford Nelson

Updated 20-Jun-18 4:45am

v2

Comments

Richard MacCutchan 16-Jun-18 5:14am

1++?

Waqar (Vicky) 19-Jun-18 12:06pm

Thanks for your help @Clifford Nelson.

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Swan · Accepted Answer · 2018-06-16T09:12:00

Solution 2

You can do most of the work in one line of code.

C#

private void RenumberPreferredSequence(Item record)
  {
    int seq = 2;
    foreach(var itemVendor in record.ItemVendors)
     {
       itemVendor.PreferredSequence = itemVendor.PrimaryVendor ? 1 : seq++;
     }
  }

Posted 16-Jun-18 9:12am

George Swan

Comments

Waqar (Vicky) 19-Jun-18 12:06pm

Thanks for your help @George Swan.
(Y)

How can I make this function code more concise rather than using multiple foreach loop ?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

How can I make this function code more concise rather than using multiple foreach loop ?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us