Read user input to struct array

Question

0.00/5 (No votes)

See more:

the program is meant to register member info into a global array member_array
the problem is that it is meant to take 9 inputs from user but when I test it .. the program takes only 6 of them before it terminates .. I don't know why!

What I have tried:

typedef struct
{
    int buildNum;//use validateNegative
    char street[10];
    char city[10];
} addressStruct;

typedef struct
{
    char name[10];
    char domain[10];

} emailStruct;

typedef struct
{
    char name[10];
    int ID;
    addressStruct address;
    int mobile;
    int age;
    emailStruct email;
    int booksBorrowed;
} member;
member member_array[50];
<pre>void registeration(void)
{

    gets(member_array[i].name);
    scanf("%d",&(member_array[i].ID));
    scanf("%d",&(member_array[i].address.buildNum));
    gets(member_array[i].address.city);
    gets(member_array[i].address.street);
    scanf("%d%d",&(member_array[i].mobile),&(member_array[i].age));
    gets(member_array[i].email.name);
    gets(member_array[i].email.domain);
    i++;
    return ;

}
int main()
{
  registeration();

  return 0;
}

Posted 6-Dec-17 17:35pm

Member 13476370

Updated 6-Dec-17 22:21pm

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-12-06T19:55:00

We can't tell - it's going to depend on exactly what you input at any time, and we can't see you typing!
So, its going to be up to you.
Fortunately, you have a tool available to you which will help you find out what is going on: the debugger. How you use it depends on your compiler system, but a quick Google for the name of your IDE and "debugger" should give you the info you need.

Put a breakpoint on the first line in the function, and run your code through the debugger. Then look at your code, and at your data and work out what should happen manually. Then single step each line checking that what you expected to happen is exactly what did. When it isn't, that's when you have a problem, and you can back-track (or run it again and look more closely) to find out why.

Sorry, but we can't do that for you - time for you to learn a new (and very, very useful) skill: debugging!

CPallini · Answer 2 · 2017-12-06T21:53:00

Solution 2

In your code, you need a global int i variable as well. Moreover you should initialize it to 0.

That said, my advices are:

Do NOT use global variables, pass local variables as parameters to your functions.
Do NOT use the gets function, use fgets instead

Posted 6-Dec-17 21:53pm

CPallini

Jochen Arndt · Answer 3 · 2017-12-06T22:21:00

The reason for reading not all input values is sourced by using gets and scanf variantly.

gets - C++ Reference[^] reads until a new line character has been read without storing the newline character in the read buffer.

scanf - C++ Reference[^] skips leading white spaces (including new line characters) and reads until the format does not match anymore. That usually lets new line characters in the system input buffer.

So there will be an unread new line character after calling scanf. When calling gets aftwerwards, that will read the new line character and stop resulting in an empty string in the passed buffer.

To avoid such problems, don't use both functions or ensure that new line characters are skipped before calling gets.

A common solution is to use fgets - C++ Reference[^] for all read operations (instead of gets as alredy suggested). For inputs that are not strings use conversion functions like atoi, atof, or sscanf for multiple parameters on one line.

Read user input to struct array

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0