Why does my filesystemwatcher use so much cpu useage? Vb.net

Question

0.00/5 (No votes)

See more:

Hi everyone this is probably my last question on here as i've learnt a lot from this site regarding vb.net, there's just one thing i can seem to figure out. My filesystemwatcher uses like 50 percent cpu usage and i was wondering if anyone could edit my code to change the usage (lower cpu useage) also tell me why it's so high. Thanks

heres code, Remember this is just one even ive got any event for renamed, created, changed, delted :::

Private Sub FileSystemWatcher1_Renamed(ByVal sender As System.Object, ByVal e As System.IO.RenamedEventArgs) Handles FileSystemWatcher1.Renamed
       Dim OpenFileDialog3 As String
       Try
           Detect.Labellastreal.Text = e.FullPath
           ListBox3.Items.Add(Detect.Labellastreal.Text)
           OpenFileDialog3 = ""


           Dim md5 As New MD5CryptoServiceProvider
           Dim f As New FileStream(e.FullPath, FileMode.Open, FileAccess.Read, FileShare.Read, &H2000)
           md5.ComputeHash(f)
           Dim hash As Byte() = md5.Hash
           Dim buff As New StringBuilder
           Dim hashByte As Byte
           For Each hashByte In hash
               buff.Append(String.Format("{0:X2}", hashByte))
           Next
           f.Close()
           If My.Computer.FileSystem.ReadAllText(Application.StartupPath & "\Database\UnwantedProgs.txt").Contains(buff.ToString) Then
               OpenFileDialog3 = e.FullPath
               File.Move(Detect.Labellastreal.Text, Path.Combine("C:\ProgramData\DreamyTS\Infected\", Path.GetFileName(Detect.Labellastreal.Text)))
               Detect.ShowDialog()

               WriteToLog("Unwanted Program detected")
           End If

       Catch exception1 As Exception
           ProjectData.SetProjectError(exception1)
           Dim ex As Exception = exception1
           ProjectData.ClearProjectError()
       End Try
   End Sub

It all works just high cpu useage

What I have tried:

im not really sure what to try to be honest...

Posted 2-Nov-17 8:00am

CodingIsDreamy

Updated 2-Nov-17 10:17am

Add a Solution

Comments

Mehdi Gholam 2-Nov-17 14:08pm

Try commenting your code and see the difference.

CodingIsDreamy 2-Nov-17 14:21pm

my code is above

Mrunal Sonawane 2-Nov-17 14:22pm

xD

CodingIsDreamy 2-Nov-17 14:20pm

i dont understand what you mean?

Mrunal Sonawane 2-Nov-17 14:23pm

He is saying that put your code in comment...
'This is a comment... Lol

Mehdi Gholam 2-Nov-17 14:24pm

Obviously the code is consuming cpu cycles, comment them out to see where it is.

CodingIsDreamy 2-Nov-17 14:27pm

Private Sub FileSystemWatcher1_Renamed(ByVal sender As System.Object, ByVal e As System.IO.RenamedEventArgs) Handles FileSystemWatcher1.Renamed
Dim OpenFileDialog3 As String
Try
Detect.Labellastreal.Text = e.FullPath
ListBox3.Items.Add(Detect.Labellastreal.Text)
OpenFileDialog3 = ""

Dim md5 As New MD5CryptoServiceProvider
Dim f As New FileStream(e.FullPath, FileMode.Open, FileAccess.Read, FileShare.Read, &H2000)
md5.ComputeHash(f)
Dim hash As Byte() = md5.Hash
Dim buff As New StringBuilder
Dim hashByte As Byte
For Each hashByte In hash
buff.Append(String.Format("{0:X2}", hashByte))
Next
f.Close()
If My.Computer.FileSystem.ReadAllText(Application.StartupPath & "\Database\UnwantedProgs.txt").Contains(buff.ToString) Then
OpenFileDialog3 = e.FullPath
File.Move(Detect.Labellastreal.Text, Path.Combine("C:\ProgramData\DreamyTS\Infected\", Path.GetFileName(Detect.Labellastreal.Text)))
Detect.ShowDialog()

WriteToLog("Unwanted Program detected")
End If

Catch exception1 As Exception
ProjectData.SetProjectError(exception1)
Dim ex As Exception = exception1
ProjectData.ClearProjectError()
End Try
End Sub

Mrunal Sonawane 2-Nov-17 14:27pm

Yeah sure it is using the cpu... but commenting it is not a good choice... It will create more errors than fix any...

CodingIsDreamy 2-Nov-17 14:29pm

oh could you fix it for me and next to the fix explain what i did wrong?

CodingIsDreamy 2-Nov-17 14:31pm

or an example or somthing

Mrunal Sonawane 2-Nov-17 14:33pm

For Each hashByte In hash
buff.Append(String.Format("{0:X2}", hashByte))
Thread.Sleep(500)
Next
...
Try this maybe

Mrunal Sonawane 2-Nov-17 14:34pm

change those lines in your code

CodingIsDreamy 2-Nov-17 14:35pm

ok two secounds :-)

CodingIsDreamy 2-Nov-17 14:34pm

ok ill try now :-)

Mrunal Sonawane 2-Nov-17 14:35pm

Sure... Let me know...

CodingIsDreamy 2-Nov-17 14:27pm

is that what you mean? cause dude if not im confused :-)

Dave Kreskowiak 2-Nov-17 15:19pm

What do you have the FileSystemWatcher watching? Did you make it watch an entire drive?

CodingIsDreamy 2-Nov-17 15:55pm

yeah dude the c:\

Dave Kreskowiak 2-Nov-17 16:14pm

There's you problem right there. See my Solution below.

CodingIsDreamy 2-Nov-17 16:14pm

ok cool

CodingIsDreamy 2-Nov-17 16:15pm

wait where? that other dude had an awnser that helped alot just saying to anyone else that reads to skip straight to yours and his is awnser

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2017-11-02T10:17:00

The FSW doesn't sit around waiting for an event from NTFS. There are no such events. So how does the FSW get changes to the file system?

Polling.

Basically, the FSW goes to every directory and subdirectory it's told to watch and grabs the list of files for them. It calls ReadDirectoryChangesW function (Windows)[^] on each directory, building a database of what ReadDirectoryChangesW function (Windows)[^] changes have happened since the last time each directory was hit by the function call. The FSW doesn't sit around waiting for an event from NTFS. There are no such events. So how does the FSW get these changes?

Polling. Basically, the FSW goes to every directory and subdirectory it's told to watch and grabs the list of files for them. Basically, it calls ReadDirectoryChangesW function (Windows)[^] on each directory. The more directories and subdirectories, the longer each polling cycle takes. Once all the directories are processed on one pass, the cycle starts all over again at the top of the directory tree it's told to watch. This is what is taking up so much CPU time.

As it goes through each folder, it starts generating the events your code sees for the changes it finds.

Since you're telling the FSW to watch thousands of folders, it's taking a ton of CPU time polling all of them to get the list of files that changed.

Basically, you're using the FSW for a task it wasn't designed to handle.

Mrunal Sonawane · Accepted Answer · 2017-11-02T08:26:00

Solution 1

Not sure but try adding a thread sleep in the loop... For like 500ms
Try that and tell me if it works

Posted 2-Nov-17 8:26am

Mrunal Sonawane

Comments

CodingIsDreamy 2-Nov-17 14:28pm

where should i add it? Example?

Mrunal Sonawane 2-Nov-17 14:34pm

For Each hashByte In hash
buff.Append(String.Format("{0:X2}", hashByte))
Thread.Sleep(500)
Next

CodingIsDreamy 2-Nov-17 14:38pm

well dude it took it down a little bit but not much of an effect from what i saw :-)

Mrunal Sonawane 2-Nov-17 14:39pm

Hmm...

Mrunal Sonawane 2-Nov-17 14:40pm

Thinking...

CodingIsDreamy 2-Nov-17 14:41pm

no prob dude im just glad your helping :-)

Mrunal Sonawane 2-Nov-17 14:46pm

No worries bro... Coding is really interesting... And trying to solve problems related to it feels nice!
Well, you can try increasing the thread sleep time... to like 1000 or 2000 or even more... Maybe that might help... Please let me know
Actually the thing is that the function is doing a lot of work... Creating objects, reading files, hashing etc etc... Which is adding on to the usage... Well, try increasing the time and tell me if it does anything at all...

CodingIsDreamy 2-Nov-17 14:54pm

ok dude cheers sorry for late reply was making a coffe :-)

Mrunal Sonawane 2-Nov-17 15:05pm

No problem bro! :D

CodingIsDreamy 2-Nov-17 15:08pm

:-)

CodingIsDreamy 2-Nov-17 15:09pm

in your opinion is a 30% cpu useage alot?

CodingIsDreamy 2-Nov-17 14:57pm

its now 30% cpu useage so it's helped! :-)

CodingIsDreamy 2-Nov-17 14:59pm

Also dude can i grab your email just incase in the future i need help with a tiny error i should'nt but i might? It's just somthimes when i ask other people dude they just say i cant code and stuff but it's just im more used to other programing languages

CodingIsDreamy 2-Nov-17 15:08pm

lol saved dude

Mrunal Sonawane 2-Nov-17 15:09pm

Lol nice... I might take sometime to reply via mail but I always do check my mail so feel free to mail me any problems you face! Always happy to help! :D

CodingIsDreamy 2-Nov-17 15:10pm

thanks man:-)

Mrunal Sonawane 2-Nov-17 15:11pm

No worries :D

CodingIsDreamy 2-Nov-17 15:14pm

Do you work in many programming languages? or just .net? just wondering cause i've met some people on here that somehow like load of programming languages, but your the only one that has been proper caring about code, like just seem to love code :-)