Why does my XML element count always return 0?

Question

4.00/5 (1 vote)

See more:

I am trying to count out the elements within a root, then add an element to that root and give it a name based on the count from the beginning. Here is my XML:

HTML

<NewDataSet>
  <Klasse>
   
  </Klasse>
  <Sub>

  </Sub>
</NewDataSet>

and here is my code:

C#

private void buttonSchSave_Click(object sender, EventArgs e)
 {

     XmlDocument xmldoc = new XmlDocument();
     xmldoc.Load("Klassen/NeueKlasse1.xml");
     int neuSchV = xmldoc.SelectNodes("Sub").Count;

     XDocument doc = XDocument.Load("Klassen/NeueKlasse1.xml");

     XElement root = new XElement("SubAdd" + neuSchV);
     var elementName = doc.Descendants("Sub")?.SingleOrDefault();
     elementName.Add(root);



     doc.Save("Klassen/NeueKlasse1.xml");





 }

The Problem is: all the elements "SubAdd" are named: SubAdd0

The Xml Element Count always seems to return the value 0, any ideas on how to solve this?

Thanks.

What I have tried:

searching for a similar problem, didn't really find anything i could use.

Posted 12-Sep-17 1:09am

Member 13405694

Updated 12-Sep-17 10:21am

Add a Solution

2 solutions

Solution 1

int neuSchV = xmldoc.SelectNodes("/NewDataSet/Sub").Count;

refer Select XML Nodes by Name [C#][^]

Posted 12-Sep-17 3:50am

Karthik_Mahalingam

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2017-09-12T10:21:00

You probably don't want to mix XmlDocument and XDocument. You end up loading the same file twice, which could become a problem if your file grows sufficiently large.

There's also no real point in counting the Sub elements, since SingleOrDefault will throw an exception if there is more than one. Did you want to count the child elements of the Sub element instead?

XDocument doc = XDocument.Load("Klassen/NeueKlasse1.xml");
if (doc.Root == null)
{
    doc.Add(new XElement("NewDataSet"));
}

XElement subNode = doc.Root.Element("Sub");
if (subNode == null)
{
    subNode = new XElement("Sub");
    doc.Root.Add(subNode);    
}

int neuSchV = subNode.Elements().Count();
XElement subAddNode = new XElement("SubAdd" + neuSchV);
subNode.Add(subAddNode);

doc.Save("Klassen/NeueKlasse1.xml");