Repalce pi with 3.14

Question

1.00/5 (1 vote)

See more:

replacing pi word with 3.14 .it is showing the output but forcing me to close the program,any help regarding this will be appreciated.

What I have tried:

C++

#include <iostream>
#include <vector>
#include <string>
#include<cstring>
#include <sstream>
using namespace std;
void swa(char b[]);
int main()
{
    char str[]="pi day is celebrated in march, pi day is on 14 march";
    swa(str);
}
void  swa(char b[])
{
    int i;
    char * str=new char();
    str=strtok(b," ");
    char *ptr1=new char();
    strcat(ptr1,str);
    strcat(ptr1," ");

    if(strcmp(str,"pi")==0)
    {
        ptr1="3.14 ";
       // cout<<ptr1<<" ";
    }
    if(str!=NULL)
    {
        cout<<ptr1;
        swa(b+strlen(str)+1);
    }
}

Posted 12-Jun-17 22:40pm

Nilesh Sinha

Updated 5-Jul-19 18:56pm

Add a Solution

Comments

Afzaal Ahmad Zeeshan 13-Jun-17 4:48am

You are not replacing the PI with 3.14 at all.

You can try using the replace function to replace the characters in a string with a new set of characters (strings).

Nilesh Sinha 13-Jun-17 13:16pm

My question is basically write a replace function instead of using in-built replace function.

3 solutions

Solution 1

There are a load of problems here, starting with prt1 not containing enough space for the data you are concatenating into it, but more importantly, you aren't using strtok even close to correctly.
Look at the documentation: strtok - C++ Reference[^] - it includes an example of how to use it. Throw that code away, and start again once you have read the documents and understand what you are doing, instead of just guessing and hoping for the best!

Posted 12-Jun-17 23:13pm

OriginalGriff

Comments

Nilesh Sinha 13-Jun-17 13:19pm

Thank you for providing the reference,i look into this code once again.

Solution 3

#include<bits/stdc++.h>
using namespace std;
void replace(char input[],int start) 
{
	if(input[start]=='\0'||input[start+1]=='\0') // base condition if string 
                  return;             //contains no element or 1 element
                                       // there won't be 
                                      //any pi as               
                       
				    // pi contains 2 characters p i
		
replace(input,start+1);//Initially start would be at 0 and increment start
                      // by 1 in each 
                      //case to traverse whole string.
	
	if(input[start]=='p' && input[start+1]=='i')
	{
		for(int j=strlen(input)-1 ;j>=start+2 ;j--)
		{
			input[j+2]=input[j]; //Shift elements by two towards right as 
                                            //3.14 contains 2 more character than 
                                            //pi
		}
		input[start]='3'; 
		input[start+1]='.';
		input[start+2]='1';
		input[start+3]='4';
		input[strlen(input)+2]='\0';
	}
}
void replacePi(char input[])
{
	replace(input,0); 
}

int main()
{
char a[1000000];
cin>>a;
replacePi(a);
cout<<a;
}

Posted 5-Jul-19 18:57pm

Member 14522494

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2017-06-12T23:43:00

Solution 2

Why do you use C-like string in C++ code?
Try:

C++

#include <iostream>
#include <string>
using namespace std;
int main()
{
  string s = "pi day is celebrated in march, pi day is on 14 march";

  size_t pos = 0;

  while ( (pos = s.find("pi", pos)) != string::npos )
  {
    s.replace(pos,2, "3.14");
  }

  cout << s << endl;
}

Posted 12-Jun-17 23:43pm

CPallini

Comments

Nilesh Sinha 13-Jun-17 13:19pm

thank you very much :)

CPallini 14-Jun-17 8:15am

You are welcome.