Code checking for mistakes

Question

0.00/5 (No votes)

See more:

I have tried to use a While Loop to search for words on button click. But the contextMenu keeps on jumping up and down or loading very quickly without stopping or showing the results. Here is the code:

VB

Private Sub CheckForReplacementText()

    If nextCheckIndex = replacements.Count Then

        MessageBox.Show("Check complete.")
        nextCheckIndex = 0

    End If

What I have tried:

To use a while loop

Posted 20-May-16 3:21am

Member 11788899

Updated 25-May-16 22:23pm

v4

Add a Solution

Comments

Matt T Heffron 20-May-16 13:37pm

Well, you are clearing and reloading the ContextMenuStrip1.Items inside the While loop, so of course it is changing multiple times!

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-05-20T03:29:00

Why are you trying to do this recursively, when it's a loop problem? Recursion is only useful when you pass a value to the method as a parameter, so that different iterations have an independent value.
And all you do is call the same method, and exit when it returns - so a loop is a much more sensible solution here.
And if at any time nextCheckIndex is greater than replacements.Count and foundIndex is zero or more ... your code will recurse forever and you will get a stack overflow - as you have found.
Try it: use the debugger and you will see what I mean.

Don't use recursion unless it's a task which genuinely needs it, or data which exhibits a recursive structure such as processing all the files in all the subdirectories of a folder. This doesn't - it's just a string of data and you are looking for bits to change...

F-ES Sitecore · Answer 2 · 2016-05-20T03:30:00

Solution 2

Debug your code to step through it line by line and that will show what the problem is. What is "replacements.Count" for example? If it is 0 then your code will loop forever, but only you can know that. If that is the issue try

VB.NET

If nextCheckIndex = replacements.Count Or replacements.Count = 0 Then

    MessageBox.Show("Check complete.")
    nextCheckIndex = 0

End If

Posted 20-May-16 3:30am

F-ES Sitecore

Comments

[no name] 20-May-16 9:42am

What about telling the user "You cannot check more than that when it finishes checking?

Private Sub BtnSearch_Click(sender As Object, e As EventArgs) Handles BtnSearch.Click

If nextCheckIndex > replacements.Count Then

MessageBox.Show("You cannot check more than that!")

ElseIf nextCheckIndex < replacements.Count Then
foundIndex += 1
CheckForReplacementText()

End If
End Sub

[no name] 20-May-16 10:08am

OK, check the updated question and code. A new problem has presented itself.