Directshow queryinterface is crashing instead of returning an error as it should be.

Question

0.00/5 (No votes)

See more:

COM

directshow

errors

, +

Hi,

Using the QueryInterface like the code below

C++

hr = m_pPISourceFilter->QueryInterface(IID_IFileOffset,(void **)&m_pFileOffset);

I always check if it fails like this

C++

if (FAILED(hr)) {
    ReportError(_T("Failed to initialize the filter (FileOffset)."),hr);
    return FALSE;
		
}

Instead of returning back a FALSE value to the caller for any cleanup procedures, the application crashes.

To test this code, the DirectShow filter is not registered and consequently the Interface IID_IFileOffice does not exist.

What seems to be wrong here ?

Regards,

What I have tried:

To catch the error using FAILED(hr) or SUCCEEDED(hr)

Posted 14-Feb-16 1:29am

sdancer75

Add a Solution

Comments

[no name] 14-Feb-16 7:40am

And you are sure that "m_pPISourceFilter" is valid?

sdancer75 15-Feb-16 10:49am

Νο m_pPISourceFilter is not valid (old COM build), but the question is why it crashes while it should return to caller. I run this only in release mode to user's machine. I suspect that it crashes somewhere inside the caller...

[no name] 15-Feb-16 11:30am

How you get m_pPISourceFilter? In case m_pPISourceFilter is NULL you have to correct this first.

sdancer75 16-Feb-16 5:45am

m_pPISourceFilter is the pointer result of a previous QueryInterface in a previous step that I have not shown here. In case of problem then the previous if (FAILED(hr)) should have catch this right ? In this case should never come to this step.

[no name] 16-Feb-16 5:48am

Yes FAILED(hr) should have catched it. Anyway I would inspect it with Debugger if possible. With what you are developing? VS, Borland?

Maybe this helps, but pay Attention, my browser tells me the site has a Problem ....
https://www.doom9.org/showthread.php?p=1646451[^]

sdancer75 17-Feb-16 12:34pm

Thanx for your time. I am using VS2008 for this project. Anyway I will debug this piece of code since I suspect that the crash is done inside the caller and not inside the piece of code I mentioned here.

PS:The article in your link it was mine :-)

Richard MacCutchan 14-Feb-16 7:55am

You need to step through the code with your debugger to the point of the crash, in order to find out why it crashed.

sdancer75 15-Feb-16 10:52am

I used an old COM build in the user's machine instead of that I used in my development machine. As I said above I suspect that the snippet works fine and it returns false as it should be, and somewhere inside the caller it crashes.

Yes I will debug the code. Thanks....

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)