How can I improve his code to prevent stackoverflow?

Question

1.00/5 (1 vote)

See more:

OK, how can I improve this code to stop the stackoverflow from happening here:

VB.NET

Public Sub CheckForReplacementText() function

The code is supposed to do Grammar checking when you press F1 to run the program. But for this to happen, you need to copy the dictionary I provided from Google in order for it to work.

The error is pointed from here:

VB.NET

foundIndex = RichTextBox1.Find(checkWord, 0, RichTextBox1.TextLength, RichTextBoxFinds.WholeWord)

The whole code is here:

VB.NET

    Private Sub RichTextBox1_KeyUp(sender As Object, e As KeyEventArgs) Handles RichTextBox1.KeyUp
        If e.KeyCode = Keys.F1 Then

            CheckForReplacementText()
        End If
    End Sub

    Public Sub ReplaceMenu_ItemClicked(ByVal sender As Object, ByVal e As ToolStripItemClickedEventArgs) Handles ReplaceMenu.ItemClicked


        For Each replacement In replacements(checkWord)

            replacement = e.ClickedItem.Text
            kamau = replacement

        Next


    End Sub
End Class

Press F1 to run the program. My dictionary can be found here:

https://docs.google.com/document/d/1eTZaIUh7Q9zkNzjZQ-lPV9yxS5eSlNs5ht2-Pl-LS14/edit?usp=sharing

Posted 17-Dec-15 2:20am

Member 11788899

Updated 25-May-16 22:35pm

v7

Add a Solution

Comments

F-ES Sitecore 17-Dec-15 8:29am

Stack overflow errors happen when your code gets into a infinite call loop, ie something like this

public void DoSomething()
{
DoSomething();
}

Use the debugger to step through your code to find out what is looping, that's the first stage. Once you know the solution might become obvious, if not update your question to say what is looping.

[no name] 17-Dec-15 9:05am

The section that is looping is the Public Sub CheckForReplacementText() function from here:

foundIndex = RichTextBox1.Find(checkWord, 0, RichTextBox1.TextLength, RichTextBoxFinds.WholeWord)

2 solutions

Solution 2

Stack overflow condition is maybe not the easiest for debugging, but it's one of the easiest. You cannot ask a question every time it happens but really want to learn how to sort out such problems all by yourself.

Here are some basic ideas. If stack overflow happens as a result of some bug, it's nearly always happens due to incorrect recursion or mutual recursion:
https://en.wikipedia.org/wiki/Recursion[^],
https://en.wikipedia.org/wiki/Recursion_(computer_science)[^],
https://en.wikipedia.org/wiki/Mutual_recursion[^],
https://en.wikipedia.org/wiki/Recursive_function[^].

If you know which of your recursive function written on purpose is a source of a problem, you can just debug it in a usual way. But what if you don't know where the problem is?

First, when you observer this exception, put a break point, at first, at the very first statement of the method shown where the exception happens under the debugger (in Visual Studio, you may want to adjust Debug/Exceptions settings). Restart the application and reproduce the condition. When the execution stops at this point, continue execution to see how this point is reached again and again.

Now, this is the key: use the debugger window "Call stack" to see where the call comes from each time. Using this information, move or add the breakpoint to the point in code closer to the source of this problem. This way, you methodically pin-point the source of the problem in few such iteration steps.

—SA

Posted 17-Dec-15 5:38am

Sergey Alexandrovich Kryukov

Comments

[no name] 17-Dec-15 11:48am

I studied the problem thoroughly. My only problem is the ingenuity to reproduce another function to ease the workload.

Sergey Alexandrovich Kryukov 17-Dec-15 13:26pm

Good. That could be a problem, if the stack overflow only happens due to non-deterministic behavior. Are you sure you cannot reproduce the same very behavior after each restart? If so, you should think of possible reasons for non-deterministic behavior, but perhaps you should just do all the observation very accurately.
—SA

[no name] 17-Dec-15 12:19pm

If we don't solve this problem as men, then the subsequent users will find the question unanswered, and then they will ask you the same question over, and over again.

Sergey Alexandrovich Kryukov 17-Dec-15 13:28pm

The similar questions have been asked too many times before, to worry about it too much. Your specific problem might be only yours, not interesting to others, only the general problem is interesting.

Now, why would you address this comment to me, "as men", and so on? Just curious...

—SA

[no name] 17-Dec-15 13:51pm

Right now am too busy for cheat chat.

Sergey Alexandrovich Kryukov 17-Dec-15 15:48pm

It's fine, but perhaps you should remember that you talk to other busy people who nevertheless tried to find time to help you. I would advise you to be a little considerate. We are helping free of charge, just to help people. I have no idea what you call "cheat chat" and, frankly, don't want to know.
—SA

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2015-12-17T03:46:00

Solution 1

You have two calls back to CheckForReplacementText in your CheckForReplacementText method. Also, there is no bailout to stop this endless process, so yeah, your code is going to throw a stack overflow error.

Why are you calling CheckForReplacementText from inside the method?

Your code doesn't make any sense at all. I have no idea what it's supposed to be doing. The CheckForReplacementText method is doing a ton more stuff than it's name suggests it should be doing.

Also, the With statement you have in there doesn't need to exist. Remove the With/End With and just leave the rest of the statement there, IF that's what your logic is supposed to be doing.

Posted 17-Dec-15 3:46am

Dave Kreskowiak

Updated 17-Dec-15 3:47am

v2

Comments

[no name] 17-Dec-15 9:50am

Yes, the code is supposed to be replacing words with suggestions from the second column from the dictionary. It uses a contextmenu to replace bad words. How can I programmingly deal with this problem after removing With/End With?

Dave Kreskowiak 17-Dec-15 9:54am

The big problem is why is the CheckForReplacementText method calling iteself?

CHill60 17-Dec-15 9:58am

Because the OP will not listen to advice given! I pointed out the recursion on one of their earlier posts. Basically I think they are getting their homework done one QA post at a time without understanding any of the answers

Dave Kreskowiak 17-Dec-15 10:11am

Figures...

[no name] 19-Dec-15 12:20pm

Can you help me with this?

[no name] 19-Dec-15 12:14pm

Can you help me with this code?

[no name] 19-Dec-15 12:20pm

I will ask you to press F1 in order to see how it grammar checks, after you copy that dictionary file I provided from Google docs. Change the path and run the program.

[no name] 17-Dec-15 10:02am

Not so, because it is very difficult to solve this problem without the help of an Expert.

Dave Kreskowiak 17-Dec-15 10:13am

No, it's difficult to solve the problem because there are basic concepts that you're not understanding.

Like I keep saying, I, and apparently you too, don't have a clue what CheckForReplacementText is supposed to be doing. Simplify this method down to doing one thing and one thing only.

Sergey Alexandrovich Kryukov 17-Dec-15 11:44am

Usually, when someone solves this problem just once or twice, following cases don't cause any serious difficulties. CHill60 says that you already had this problem before and got answers; and this is easy to check up. If your problem is not understanding the answer, helping you through the forum would be nearly useless.
—SA

[no name] 19-Dec-15 12:21pm

The question is still open if your ready to answer.

Dave Kreskowiak 19-Dec-15 12:32pm

You've already gotten answers, from all over the web. This is not the only site you posted this question to.

The problem is that you cannot understand the answers. This makes me wonder who really wrote this code because it's obvious you have no idea what it's doing and why the CheckForReplacementText method is calling itself.

Any answer you get is going straight over your head and no, nobody is going to write the code for you.

[no name] 19-Dec-15 13:17pm

I know by your statement, I don't deserve it. I talked to a guy in Microsoft to help me. But now they are not available. I only need help so that I can help the world also. This is all I have left. If you can help me with this only, I will never even have to come to this forum again.

[no name] 19-Dec-15 13:34pm

Please reply before the day is over.

Dave Kreskowiak 19-Dec-15 17:54pm

One, I don't work for you. I don't report to you. You making demands on when someone should answer or is exceedingly rude.

Two, you already have the answer to your question, "why do I get a stack overflow?" We here have already told you why. Other people on other sites that you seem to have spammed your question all over have also told you the same things.

You have gotten the answers to your question. It's not our fault that you cannot understand them. These are simple concepts you're not understanding. We can't do anything about that.

You also cannot tell us why you wrote the code you supposedly did. Again, why do you have CheckForReplacementText calling itself? You are constantly ignoring that question, which makes me think you didn't write this code and you don't understand the first thing about it. If you can't do that, there is no hope of you understanding the answers you've gotten.

[no name] 20-Dec-15 5:02am

I know now you cannot help me. I thought that this is what you do here, but now you are answering to frustrate me. You will never help me, and never tell people that you help others, and that God knows what you do, and that is why he will bless you. I have read several questions posted on this forum, and this is the kind of thing I see. Mockery!

Dave Kreskowiak 20-Dec-15 10:16am

You haven't answered anything you've been asked on the code, other than "I want to replace text".

WHY ARE YOU CALLING CHECKFORREPLACEMENTTEXT FROM INSIDE CHECKFORREPLACEMENTTEXT!?!?!?!?!?!?! THIS IS WHY YOU ARE GETTING STACKOVERFLOW ERRORS ALL THE TIME!

[no name] 20-Dec-15 10:48am

I am not sure why this is called, but it is supposed to repeat the process. If the code is removed,it doesn't work. If you press F1, there is no result, but if you return the repeated function at the bottom. It works!

[no name] 20-Dec-15 11:08am

I have improved the performance of the code, you can check it, but still needs some adjustment against the stackoverflow.

[no name] 20-Dec-15 5:03am

You're even doing a background check on me which causes me to wonder if you're hackers.

Dave Kreskowiak 20-Dec-15 10:14am

No, all I did was search for one little piece of code you posted and all kinds of results came up on other forums.

[no name] 17-Dec-15 10:16am

Dave, you are putting the pressure, but thanks. Are we meant to bring each other up or down? What will it cost you to help me with this sought of problem? I have been working the whole yesterday to create a separate function for this to reduce the overload.

Dave Kreskowiak 17-Dec-15 11:00am

You to explain EXACTLY what this code is supposed to do in very fine detail.

If you can't explain it to us, you have no hope at all of explaining it to a computer, which is FAR more picky.

Sergey Alexandrovich Kryukov 17-Dec-15 11:54am

No, you are putting the pressure with your "what will cost you?" :-)

But more seriously, my advice would be: better don't mention the "pressure". This is the forum base of free exchange of information. "Pressure" is logically impossible, can only be in the head of some unstable persons. If you don't want to use help, don't. The advice is perfectly valid. And your "working the whole yesterday" cannot be used as an argument. If you worked whole day to refactor out just one function, it's perfectly fine and it only tells everyone that you need to lean how to work better. This is normal situation, learning.

But here is the idea: the more you do with your own hands to solve the problem, the better. The more you learn, the better. This is not the last function in your life. You need to learn at least the basics. This question is about the basics, so use the situation for your benefits.

—SA

[no name] 17-Dec-15 12:12pm

Usually when its Christmas, we don't talk like that, but we eat red onion, and enjoy some Lado.

Sergey Alexandrovich Kryukov 17-Dec-15 13:23pm

Nobody invited to accuse anyone before Christmas in "pressing", but it would be fine. I just give you some useful advice, did not mean to be negative and very sorry that you perceive anything here as negative and would advise you not to think this way. Rather, please understand that everyone is trying to help you here, including myself. If not, how do you thin, would I waste time for my answer?

Good appetite!

—SA

[no name] 17-Dec-15 13:27pm

Nice time. I will try to work on an answer.

Sergey Alexandrovich Kryukov 17-Dec-15 13:31pm

Same to you. Good luck. Will gladly try to help with your future questions.
—SA

[no name] 17-Dec-15 11:08am

Let me send you the whole code to make it clear, but the whole code is meant to correct grammatical mistakes with suggestions from the second column from a dictionary with help of a ContextMenu.

[no name] 17-Dec-15 11:11am

Press F1 to run the program. The dictionary can be found here:

https://docs.google.com/document/d/1eTZaIUh7Q9zkNzjZQ-lPV9yxS5eSlNs5ht2-Pl-LS14/edit?usp=sharing

[no name] 17-Dec-15 11:20am

Check the whole code.

Sergey Alexandrovich Kryukov 17-Dec-15 11:40am

My 5. And I added Solution 2 to suggest the debugging methods in general case.
—SA

How can I improve his code to prevent stackoverflow?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

How can I improve his code to prevent stackoverflow?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us