Click here to Skip to main content
15,907,910 members
Home / Discussions / C / C++ / MFC
   

C / C++ / MFC

 
GeneralRe: GetVCPFeatureAndVCPFeatureReply fails when called Pin
Valentinor10-Oct-23 6:51
Valentinor10-Oct-23 6:51 
QuestionI'm looking for review in terms of readability, approachability of this code Pin
honey the codewitch4-Oct-23 14:37
mvahoney the codewitch4-Oct-23 14:37 
AnswerRe: I'm looking for review in terms of readability, approachability of this code Pin
Gerry Schmitz4-Oct-23 18:32
mveGerry Schmitz4-Oct-23 18:32 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
honey the codewitch4-Oct-23 23:36
mvahoney the codewitch4-Oct-23 23:36 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
Gerry Schmitz5-Oct-23 5:51
mveGerry Schmitz5-Oct-23 5:51 
AnswerRe: I'm looking for review in terms of readability, approachability of this code Pin
Richard MacCutchan4-Oct-23 20:52
mveRichard MacCutchan4-Oct-23 20:52 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
honey the codewitch4-Oct-23 23:31
mvahoney the codewitch4-Oct-23 23:31 
AnswerRe: I'm looking for review in terms of readability, approachability of this code Pin
jschell5-Oct-23 5:28
jschell5-Oct-23 5:28 
honey the codewitch wrote:
I was wondering how difficult it is to follow


Presuming it is the docs and not the code...

Some review comments...(I didn't review completely - just randomly jumping around.)

I suggest that you use a different name than 'GFX'. Possible that you might even be required to since a company uses that. Also makes it easier to google for information on it if it much more unique.

You just start right up into what I can only presume is the setup. I say presumably because you do not actually state that. As an intro? example there should only be one example.

Myself I prefer that code blocks are indented from explaining text.

There is nothing in the entire document about exceptions or errors. Nor troubleshooting.

----------------------------------


Pixels
Intro is a bit odd.
There are subsections but those are not in the table of contents?
Pixels section is also hanging out by itself in table of contents.
Perhaps Pixels should be under 'Addendum'? Seems like it might fit.

Arduino TFT Bus
Lots of stuff like 'PIN_NUM_CS' in code. Is that a stand in for actual hard value? A macro that user must define? From the library (your library) that you reference?

Streams
This seems extreme. Anyone that is going to be using this successfully needs to already understand a fairly high level of programming. So is this section needed?

Suspend and Resume
What happens if there is a suspend but then I want to stop completely?

Drivers
This is in the wrong location based on the content (sparse). This and what you put in the header suggests you need a section on setting up to use the library including decisions (with examples) that one might make.

Tools
Fontgen seems to make sense to me but Bingen doesn't.

Always concerning to me when header files initialize data. Which is what the text seems to suggest with 'test_dat_stream'?

There is an odd 'performance' link at the bottom of this page?
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
honey the codewitch5-Oct-23 5:30
mvahoney the codewitch5-Oct-23 5:30 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
honey the codewitch5-Oct-23 5:55
mvahoney the codewitch5-Oct-23 5:55 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
k50545-Oct-23 6:35
mvek50545-Oct-23 6:35 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
Gerry Schmitz5-Oct-23 7:54
mveGerry Schmitz5-Oct-23 7:54 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
Richard MacCutchan5-Oct-23 21:46
mveRichard MacCutchan5-Oct-23 21:46 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
jschell6-Oct-23 7:12
jschell6-Oct-23 7:12 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
honey the codewitch6-Oct-23 7:40
mvahoney the codewitch6-Oct-23 7:40 
GeneralRe: I'm looking for review in terms of readability, approachability of this code Pin
Gerry Schmitz6-Oct-23 11:44
mveGerry Schmitz6-Oct-23 11:44 
QuestionFor loop Pin
Calin Negru25-Sep-23 5:27
Calin Negru25-Sep-23 5:27 
AnswerRe: For loop Pin
Victor Nijegorodov25-Sep-23 5:32
Victor Nijegorodov25-Sep-23 5:32 
GeneralRe: For loop Pin
Calin Negru25-Sep-23 5:42
Calin Negru25-Sep-23 5:42 
AnswerRe: For loop Pin
Randor 25-Sep-23 5:36
professional Randor 25-Sep-23 5:36 
GeneralRe: For loop Pin
jschell25-Sep-23 7:25
jschell25-Sep-23 7:25 
QuestionRe: For loop Pin
Randor 25-Sep-23 7:48
professional Randor 25-Sep-23 7:48 
AnswerRe: For loop Pin
jschell26-Sep-23 5:10
jschell26-Sep-23 5:10 
GeneralRe: For loop Pin
Randor 26-Sep-23 5:38
professional Randor 26-Sep-23 5:38 
GeneralRe: For loop Pin
jschell27-Sep-23 5:23
jschell27-Sep-23 5:23 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.