Bugs and Suggestions

19-Sep-16 8:09

I noticed a few style aspect were ignored (both in survey reply and Lounge) such as color and text-shadow. Not all, however.

A view of the page source showed that some items were removed from the post, some not.

Is this by accident or (shudder and gasp) design?

Ravings en masse^
"The difference between genius and stupidity is that genius has its limits." - Albert Einstein
"If you are searching for perfection in others, then you seek disappointment. If you are seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010

Chris Maunder19-Sep-16 9:23

19-Sep-16 9:23

Yep - we've had to crack down on our HTML cleaning.

Are there styles you want access to? Easy enough for me to review and add.

cheers
Chris Maunder

W∴ Balboos, GHB19-Sep-16 10:27

19-Sep-16 10:27

Wellllll -
I like an occasional text-shadow and box-shadow.
I love to (ab)use color and background-color now and then.

Hope that's not too many.

Thanks for whatever you can release.

a/k/a Grandpa ToFu

Ravings en masse^
"The difference between genius and stupidity is that genius has its limits." - Albert Einstein
"If you are searching for perfection in others, then you seek disappointment. If you are seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010

Chris Maunder19-Sep-16 11:37

19-Sep-16 11:37

Make me a post. Make it wondrous.

I'll make it work.

cheers
Chris Maunder

W∴ Balboos, GHB20-Sep-16 1:16

20-Sep-16 1:16

Not half so wondrous as it could be

but importing graphics opens a real can-o-worms
and I don't know what positioning will do to a page
I didn't checked for blocked HTML types (except select, input, button) but they invite havoc
And JavaScript would surely beckon madness, itself

Power to the Hamsters!

Power to the Munsters!

Power to the Hamsters!

Power to the Hamsters!

Ravings en masse^
"The difference between genius and stupidity is that genius has its limits." - Albert Einstein
"If you are searching for perfection in others, then you seek disappointment. If you are seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010

Chris Maunder21-Sep-16 13:48

21-Sep-16 13:48

Importing graphics is not (yet) allowed. It's inevitable though.
Positioning is verboten. It allows all sorts of messing up and general sneakiness.
No form elements for about a billion reasons
Yeah. Let's not even go there. (In fact XSS is the reason for the major revamp of our filtering)

cheers
Chris Maunder

W∴ Balboos, GHB22-Sep-16 0:54

22-Sep-16 0:54

Actually - just the plain styles (which you did) cover almost everything I would do. Thanks!

After you mentioned it, I realize how much fun one could have adding their own text to places it ought not go. Mainly I was looking for the (now restored) the colors and shading.

Images =>troll => Uh-Oh image at work => Uh Oh. Maybe, unless any file with an image reference goes to the is-it-spam-box holding cue. And, of course, once posted and if it's an off-CP-site reference, then the image could be replaced by the user with an overlay of the original safe image any time thereafter. I'd love to see how this can be solved without having to upload the images to a CP PetaByte storage area.

Ravings en masse^
"The difference between genius and stupidity is that genius has its limits." - Albert Einstein
"If you are searching for perfection in others, then you seek disappointment. If you are seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010

Chris Maunder22-Sep-16 2:57

No notifications since Thursday...

22-Sep-16 2:57

Exactly.

However, storage is cheap so we could store on our servers easily and moderate once.

We allow images in articles, so there's a precedent. Not having them in forums is nice since it means they are readable and not prone to massive image dumps (and MB downloads) you see in other forums.

cheers
Chris Maunder

Kornfeld Eliyahu Peter17-Sep-16 7:27

Kornfeld Eliyahu Peter

17-Sep-16 7:27

I can't see any checkboxes out on my settings page...

Skipper: We'll fix it.
Alex: Fix it? How you gonna fix this?
Skipper: Grit, spit and a whole lotta duct tape.

Re: No notifications since Thursday...

Chris Maunder17-Sep-16 14:23

Re: No notifications since Thursday...

17-Sep-16 14:23

Your account seems fine. Have you checked spam filters?

cheers
Chris Maunder

Kornfeld Eliyahu Peter17-Sep-16 20:47

Kornfeld Eliyahu Peter

17-Sep-16 20:47

Nothing caught in the spam... As always, I wasn't active on weekend so the only notifications I missed was about this post: The Lounge[^]
Now what is really interesting that all notifications arrived immediately after your answer here...
It may be something about gmail...
In any case, thank you for checking... Thumbs Up | :thumbsup:

Skipper: We'll fix it.
Alex: Fix it? How you gonna fix this?
Skipper: Grit, spit and a whole lotta duct tape.

QA Answers: smiley codes no longer work?

OriginalGriff16-Sep-16 4:33

OriginalGriff

16-Sep-16 4:33

Codes like :laugh: no longer seem to generate Laugh | :laugh:

Is this by design?

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Re: QA Answers: smiley codes no longer work?

Chris Maunder21-Sep-16 6:49

Re: QA Answers: smiley codes no longer work?

21-Sep-16 6:49

They've been removed.

QA is serious business. Very serious. There shall be no smiling allowed.

(You think it's worth bringing back?)

cheers
Chris Maunder

OriginalGriff21-Sep-16 8:00

OriginalGriff

21-Sep-16 8:00

Chris Maunder wrote:
You think it's worth bringing back?

What, QA? Well, there are times when...

Oh. Right. See what you mean. Smileys. Right. Blush | :O

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

What's is going on with code formatting?

Maciej Los16-Sep-16 1:10

16-Sep-16 1:10

Seems, using <pre></pre> tags causes embedded text deletion. See: How to make existing nodes as a child of a node in XML using C#[^]

I observed the same behaviour yesterday too while posting an answer to that question: http://www.codeproject.com/Answers/1129373/Copy-all-nodes-of-a-parent-and-append-it-in-the-pa[^]

Richard Deeming16-Sep-16 2:41

Richard Deeming

16-Sep-16 2:41

Are you sure there was ever any code in that question? Looking at the revision history[^], I can't see any.

And it's not just that he forgot to HTML-encode his XML; there's nothing in the source of the page either.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Maciej Los16-Sep-16 2:45

16-Sep-16 2:45

Are you sure that OP didn't try to paste a code?

As i mentioned, i've struggled the same yestaerday.

Richard Deeming16-Sep-16 2:52

Richard Deeming

16-Sep-16 2:52

Maybe it was related to yesterday's interesting deployment[^]?

It doesn't seem to be affecting new questions in QA, so if it was a bug, it looks like it's fixed already.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Chris Maunder21-Sep-16 16:40

21-Sep-16 16:40

Maciej Los wrote:
i've struggled the same yestaerday

What specifically wasn't working? Do you have an example I can test against?

cheers
Chris Maunder

Maciej Los21-Sep-16 20:24

21-Sep-16 20:24

Well... As i mentioned, using <pre></pre> tags causes embedded text deletion. Follow the link provided in a previous post.

For example, a result 1 should contain all nodes between <Types></Types> tags, but is has been cutted to:<Type>part of content here</ObjectType>. Note, that when i use "Improve answer" widget i see entire content! Another issue is that that a lang property for pre tag is missing. Whenever i tried to add this in pre tag, it has been removed. It should be: <pre lang="XML"></pre>

Is it clear now?

Chris Maunder22-Sep-16 3:29

22-Sep-16 3:29

Maciej Los wrote:
Follow the link provided in a previous post

I saw that and there's a question as to whether the poster actually included code, or whether they included code as actual HTML instead of HTML encoding it (HTML code within PRE blocks automatically gets HTML encoded, so I'm guessing it was the former)

HTML

<html>
<p>This should all be encoded.</p>
</html>

I just noticed you added a link to another instance of tags being removed. I added "lang=xml" to that block and everything's now fine. However, I've added that code as a test case because it's the colouriser that's killing it, not the HTML cleaner. We'll get this fixed.

Maciej Los wrote:
Another issue is that that a lang property for pre tag is missing

That's just been fixed.

cheers
Chris Maunder

Maciej Los22-Sep-16 3:33

22-Sep-16 3:33

Thank you, Chris.

Cheers,
Maciej

Chris Maunder16-Sep-16 3:51

16-Sep-16 3:51

At a guess what may be happening is the person pasted in XML without HTML encoding it, and it was stripped. I'd have to check.

Pasted in HTML/XML is meant to be HTML encoded if inside a PRE block, but the code has changed a lot over the last week in order to crank up security. We've previously been fairly loose about what we allow, but we can't do that anymore so we've been erring on the side of caution.

I'll add this as a bug to check and if my guess is true it should be a simple fix.

In the meantime: encode your HTML when pasting in code blocks Smile | :)

cheers
Chris Maunder

Maciej Los21-Sep-16 20:26