|
VeganFanatic wrote: do I need to use the exitthread anywhere?
Impossible to say; it depends what your program is actually trying to do. Are you sure you need multiple threads?
The best things in life are not things.
|
|
|
|
|
Putting that module into a thread was to make the program able to quit at any time.
This was to make sure the message handler is able to get messages.
http://www.contract-developer.tk
|
|
|
|
|
From looking at the code you posted, its probably because another thread accesses or destroys output while the thread is still using it. The way you're using the string is also very bad practice since you're forcing it to reallocate memory constantly for the string and this is very inefficient. Why not get all the information you need once, then allocate/format your string? This would allow the thread to run way faster and more efficiently.
|
|
|
|
|
When you have this run on one thread, does it complete properly?
I would do 3 things to trouble shoot and improve the code:
1) Add another command to your console entry, that allows you to start the "showtime" function, and run it one the same thread. Verify that it functions properly.
2) Enable Exceptions. I assume you are using Visual Studio of some sort, if not you will have to figure out how to do this for your debugger. In Visual Studio you can do this at the Debug | Exceptions Menu. Enable: C++ Exceptions, Native Run-Time Checks and Win32 Exceptions.
When you run your application in the debugger and it crashes, you will be right at the point in code the exception is thrown. Then you can look at the stack and all of the other helpful information.
3) Break up all of the work done in "showtime" into a smaller pieces. Probably a common function that prints out the basic text and runs the test you initiate. Then in "showtime" you would make multiple calls to your smaller function. This will help make your code more manageable.
From looking at your code, my guess is that one of the test routines is returning a NULL or some value that the string functions dont like, or is failing internally.
|
|
|
|
|
Hello all,
Could anyone please give me a efficient method and suggestions for the following.
I have many classes already in my VC++ project, which were build on MFC. Meaning the data types were MFC based. like CByteArray, CString etc etc. Now I need to avoid the uses of MFC data types , and introduce STL data types.
could you please give me an efficient and less time consuming method to migrate the same. For eg: shal I use my own classes to mimic MFC classes like CString. or correct each uses/mehtod of MFC classes wherver there is, and change with STL based methods.... I am a bit confuse. please suggest me
thanks in advance
Hrishi
|
|
|
|
|
Hi Hrishi,
hrishi321 wrote: I have many classes already in my VC++ project, which were build on MFC. Meaning
the data types were MFC based. like CByteArray, CString etc etc. Now I need to
avoid the uses of MFC data types , and introduce STL data types.
As MFC internally uses its own collection and string classes, you will increase your code footprint, and keep dependancy on all MFC classes and data types.
Anyhow you can use CStdString[^] as drop-in replacement for CString, and you should write your own CStdByteArray etc.. based on STL collections and exposing the same interface as the matching MFC collections. It could be an interesting CodeProject article 
Good luck!
AR
When the wise (person) points at the moon the fool looks at the finger (Chinese proverb)
|
|
|
|
|
Thank you so much for your kind suggestion.
I already started my implementation. Thought I am sure, I will have small doubts on my path.
As a starter, I am trying to implement the CBytearray, Could you please tell me, whether do I need to implement FreeExtra() method of MFC CBytearray, in my stl:: vector? . Is there any methods to mimic this? Or actually STL tales care of it own?
|
|
|
|
|
Hi,
If your compiler supports C++2011 (VC2010 or gcc 4.5) std::vector::shrink_to_fit() is the functional equivalent to CByteArray::FreeExtra().If you are on C++2003 use v.reserve(v.size()) to achieve the same goal.
cheers,
AR
When the wise (person) points at the moon the fool looks at the finger (Chinese proverb)
|
|
|
|
|
There's A LOT that goes into writing a framework, so you certainly don't want to write your own replacement classes. Depending on how much of the project is MFC based, you may have issues trying to replace with only STL calls. Some concepts don't exactly translate well, for example, what is a CDialog (the base for creating dialogs in MFC)? Well, its a bunch of WinAPI calls that create windows, configure properties, and act as a container for code within the dialog. How would you replicate that with STL alone? You can, but its a lot of work, STL is not exactly a framework that comes equipped as an MFC replacement (or replacement for any type of framework for that matter).
|
|
|
|
|
thanks for your suggestion. After doing a small research and checking the amount of use of the MFC types, I have decided to implement the MFC types, whichever are in my project, and of-course not all methods but eh necessary ones.
I will have many doubts during this course of time, Hope to keep getting advices from you
thanks
hrishi
|
|
|
|
|
Why do you want to do that! Horses for Courses.
Do you also want to migrate from Exel to Word?
Regards,
Bram van Kampen
|
|
|
|
|
I have this code below that updates a dbf file now this code before also updates a cdx file but I changed something in the values I added now the cdx file is not inline with the dbf.
I have tried to "reindex" and "SET INDEX TO" however everytime I do an insert in the dbf table the modified date of the cdx file stays the same as the old one.
Should the cdx be updated everytime there is something new inserted?
DIAGNOSTICS_CHECKPOINT;
LOG(L"AutoLoad File Connection String");
LOG(this->_connectionstring.c_str());
cnn->CursorLocation = adUseClient;
try { hr = cnn->Open(this->_connectionstring.c_str(), L"", L"", 0); }
catch (_com_error& e)
{ wss.str(L"");
wss << L"Opening the AutoloadFile connection from '"
<< _connectionstring.c_str()
<< L"' has failed (COM Error: " << e.ErrorMessage()
<< L", " << hr << L")."
<< std::endl;
LOG(wss.str().c_str());
throw;
}
DIAGNOSTICS_CHECKPOINT;
wss.str(L"");
wss << L"INSERT INTO "
<< this->_tablename
<< L" VALUES ('"
<< trans_id << L"','"
<< params << L"','"
<< status << L"',"
<< rec_no << L")"
;
DIAGNOSTICS_CHECKPOINT;
std::wstring sql(wss.str().c_str());
LOG(L"Executing INSERT into the autoload file");
LOG(sql.c_str());
try
{ rs->Open(sql.c_str(), cnn.GetInterfacePtr(),
adOpenForwardOnly, adLockReadOnly, adCmdText);
}
catch (_com_error& e)
{ wss.str(L"");
wss << L"Executing SQL statement:\n"
<< sql.c_str()
<< L"'\n...has failed (COM Error: "
<< e.Error() << L", '"
<< e.ErrorMessage()
<< L"')."
<< std::endl;
LOG(wss.str().c_str());
throw;
}
|
|
|
|
|
Hi All
I am working on a localization project.
I am trying to localize the Tool tips of the Tool bar buttons that are coming in English.
Tool tips are specified in the resource as direct strings in the prompt field of the properties.
Can you please advice me on how to refer the strings from String Table instead.
Any help is appreciated.
Thanks in advance.
Selva
|
|
|
|
|
Insert new 'String Table' resource. Add your strings to it. Use LoadString function to get the strings.
|
|
|
|
|
Hi Selva,
SelvaKr wrote: Tool tips are specified in the resource as direct strings in the prompt field of
the properties.
The VC resource editor intends to help you to create toolbar tooltips, they are actually in the resource stringtable.
For instance in your .rc file you have:
STRINGTABLE
BEGIN
ID_FILE_NEW "Create a new document\nNew"A toolbar button's tooltip is the part of the string resource with same ID following '\n'.
As the part preceding '\n' is the status bar text when a menu entry with same ID is hovered you can localize the strings matching your menus and toolbars in one step.
cheers,
AR
When the wise (person) points at the moon the fool looks at the finger (Chinese proverb)
|
|
|
|
|
So in porting my VS6 MFC app to VS2010 I'm plagued with hundreds of C4407 warnings. And Google is giving me no joy on how to fix it.
(...cast between different pointer to member representations, compiler may generate incorrect code...
...Compiling with the /vmm might help...)
So the question is, can I ignore the warning? How likely is this "incorrect code" and what might be the result? (I end up in the wrong base class?)
|
|
|
|
|
Kyudos wrote: So the question is, can I ignore the warning?
Well, possibly, but it depends on what you are doing. The warning comes from the use of a cast that may lead to the compiler making a wrong assumption about what you are trying to do. It would be better if you asked yourself why you have so many cast operators and what are they there for? Perhaps if you posted some of the code where the error occurs it may help someone to offer a better suggestion.
The best things in life are not things.
|
|
|
|
|
I get the warning from just about every message map function in every dialog - I'm not explicitly casting anything - it's a multiple inheritance thing. I've seen suggestions that the order of the declaration of the base classes is important, but that isn't my issue. The majority of my derived classes have a single base class so there is no order to change. This makes me lean toward the declaration of the (ultimate) virtual base class - I've seen other suggestions that "un-virtualising" it might also solve the problem. I was trying to figure out the best approach before I start changing code all over the shop.
(Whoever originated the code (not me) took the approach of using a base class for most of the classes in the application. The dialogs, for instance, are all derived from the dialog base class which itself is derived from CDialog. All the dialogs are specialisations of this. The class structure is a bit of a nightmare to be honest, but that's what I'm dealing with)
|
|
|
|
|
Why don't you pick out the first occurance of the warning, and post the applicable code along with the exact message in the warning. I can probably tell you why you get the warning and how to fix it. VS6 used to let you get away with a lot that the newer, stricter implementations of the vc compiler will either warn you about, or not let you do it at all.
One such case is taking data from one format to another without explicit casting:
float pi = 3.1415;
int i_pi = pi;
int i_pi = (int) pi;
|
|
|
|
|
OK...thanks Albert.
On this line:
ON_BN_CLICKED(IDC_RADIO_SUITABLE, OnCheckShowAll)
I get:
warning C4407: cast between different pointer to member representations, compiler may generate incorrect code
that is in the message map of the ValveSummaryDlg class.
the class hierarchy at that point is:
WndBase
Dialog : virtual public WndBase
DialogBase : public Dialog, public CDialog
GridBase : virtual public WndBase
GridDlg : public DialogBase, public GridBase
ValveSummaryDlg : public GridDlg
|
|
|
|
|
Looks like what the compiler's trying to tell you is that the pointer to the function is ambiguous...
Try this (assuming that's the location of the method), not sure if it'll fix it, but it should be more specific:
ON_BN_CLICKED(IDC_RADIO_SUITABLE, &ValveSummaryDlg::OnCheckShowAll)
...Oh, and this is definitely due to the multiple inheritance...
Another thing to try...
DialogBase : public CDialog, public Dialog
modified on Monday, June 20, 2011 11:20 PM
|
|
|
|
|
It was a good idea Albert - but it doesn't work 
|
|
|
|
|
Why are you deriving from both Dialog and CDialog?
|
|
|
|
|
Long answer...
The application is a CAD program, so many of the dialogs have common elements (line style selection, line width selection, layer etc.). The "Dialog" class contains functions that deal with these common elements.
Short answer...
Because that's how it was done when I inherited the code and I haven't changed it 
|
|
|
|
|
Well, the root of your problem is the multiple inheritance coupled with the ON_BN_CLICKED() macro definition static cast:
#define ON_BN_CLICKED(id, memberFxn) \
ON_CONTROL(BN_CLICKED, id, memberFxn)
#define ON_CONTROL(wNotifyCode, id, memberFxn) \
{ WM_COMMAND, (WORD)wNotifyCode, (WORD)id, (WORD)id, AfxSigCmd_v, \
(static_cast< AFX_PMSG > (memberFxn)) },
Here's an article on those pointers:
http://www.informit.com/guides/content.aspx?g=cplusplus&seqNum=142[^]
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
