The Weird and The Wonderful

Rob Grainger wrote:

but as he retired a while ago...

bool bMandatory = false;
bool CheckMandatory()
{
  if (someCondition)
  {
    ...;
    bMandatory = _someMember.CheckMandatory(..., "Standard");
    return bMandatory;
  }
  return false;
}

bMandatory = CheckMandatory();

Bernhard Hiller wrote:

What about the implementation in _presenter.Controller?

bool bStandardMandatory = false;

internal bool CheckMandatory(object rep, string entityname)
{
  return bStandardMandatory = ReportConfigurationService.CheckMandatory(DataContext.DataContext, rep, entityname);
}

public bool CheckMandatory(dboDataContext datacontext, object rpt, string entityname)
{
  return ReportInterface.CheckMandatory(datacontext, rpt, entityname);
}

Jeroen De Dauw wrote:

Just returning the value without casting it to boolean first! Definitely a horror!

leppie wrote:

Now I have to fix this crap and 100's of similar crap pieces of code just to understand it.

result = true;
Debug.Assert(result == true);

pg--az wrote:

How embarrassing, I did not immediately notice the issue with "redefining ==" - you are rewarded with a free book tip, Jeff Johnson's latest "Designing with the Mind in Mind", might be alternately titled "Don't even TRY to make me think". This is a brief very-well-edited book, if you haven't got a lot of time the book-price for this slim volume is OK because you learn a lot in few pages, there's no "padding".

pg--az wrote:

Also on the same topic, somewhere in Gary Kasparov's "How Life Imitates Chess", he describes how he carefully designed his first try at a chess website, because after all who could be expected to think more than world-class-chess-player-wannabe's. But the usability cameras captured these folks just instinctively clicking without a conscious thought, the way we all do, sigh.