Re: File copying, byte by byte, w/progress bar - C# Discussion Boards

2-Jul-08 1:42

Hi. I want to create a dialog which shows the progress of a file copy operation. I'll be copying a batch of files, some of which are up to 40Mb, so I want to display the current file progress aswell as the total progress. The problem I'm having is when I invoke the method for updating the UI. Because I want to update each for file I'm having to cycle through the source file byte by byte and then invoke the method which is using up all my memory. This is what I have so far. Any help would be appreciated.

FileCopyDialog.zip[^]

Re: File copying, byte by byte, w/progress bar [modified]

Scalee2-Jul-08 2:01

Scalee

2-Jul-08 2:01

Maby its just me but what are you doing?

I see these totaly useless loops, why dont you just use File.ReadAllBytes and then write it out to file again and if you must have a byte by byte view. You can easily loop trough the byte array and write it out one by one.

And your why dont you just use the worker report progress function?

Well i hope this helps and maby i just dont get the picture.

ajtunbridge2-Jul-08 2:17

2-Jul-08 2:17

Cheers for the reply. As I said, I need to display the current transfer progress for each file aswell as the total progress for all files so I need to write byte by byte (which it is doing) and then update the UI's progress bar with the current progress after each byte has been written. I'm not sure which loops you see as unnecessary btw as all 3 of them have a purpose. As for the workers' ProgressChanged event, it only has one value for percent complete and I need two.

modified on Wednesday, July 2, 2008 8:23 AM

Anthony Mushrow2-Jul-08 2:41

Anthony Mushrow

2-Jul-08 2:41

First off, ignore the ReadAllBytes suggestion, if your files are 40MB and you do have a few of them then its going to suck up alot of memory.

If you copy the file like this, you will be able to keep track of where you are:

const int BUFFERSIZE = 32768; //32KB
int bytesRead = 0;
long totalBytesRead = 0;
long fileSize = 0;
FileStream input = new FileStream("myfile", FileMode.Open);
FileStream output = new FileStream("mydestination", FileMode.Create);
byte[] buffer = new byte[BUFFERSIZE];
fileSize = input.Length;
.
while(totalBytesRead < fileSize)
{
  bytesRead = input.Read(buffer, 0, BUFFERSIZE);
  output.Write(buffer, 0, bytesRead);
  totalBytesRead += bytesRead;
}

Don't copy the file one byte at a time either, it will just go really slow. You can see your progress by checking totalBytesRead against fileSize.

Infact, you could set up an event and fire it in the while loop. Your main thread could then use this to update your progress bar etc.

My current favourite word is: I'm starting to run out of fav. words!

-SK Genius

Game Programming articles start -here[^]-

ajtunbridge2-Jul-08 3:05

2-Jul-08 3:05

Legend! Marriage proposal is in the post Smile | :)

Spacix One2-Jul-08 6:08

Spacix One

2-Jul-08 6:08

I'm not sure I'd would do this the same way, totalBytesRead would have to be class variable and volatile to display it on the UI. Else the worker has a copy of the original data and can't change it.

Why not use a delegate you could invoke to update the UI from the worker?

-Spacix
All your skynet questions[^] belong to solved

I dislike the black-and-white voting system on questions/answers. Dead | X|

Anthony Mushrow2-Jul-08 6:11

Anthony Mushrow

2-Jul-08 6:11

I did say you could set up an event and trigger that during the loop, you would pass a copy of totalBytesRead and fileSize through that to the main thread.

My current favourite word is: I'm starting to run out of fav. words!

-SK Genius

Game Programming articles start -here[^]-

ajtunbridge3-Jul-08 0:45

MS Visual Studio compiling [modified]

3-Jul-08 0:45

This is an example of what I've done, just in case anybody else needs something similar in the future. Cheers for your help guys.

FileCopyTest.zip[^]

ALAQUNAIBI2-Jul-08 1:14

ALAQUNAIBI

2-Jul-08 1:14

Hi All,

I am encountered a problem when I build my project , all Time "Compilation Error" appear !!!

what is the problem?

how can i solve that's problem ?

Ala Qunaibi
Smile | :)

modified on Wednesday, July 2, 2008 7:28 AM

leppie2-Jul-08 1:34

leppie

2-Jul-08 1:34

ALAQUNAIBI wrote:
what is the problem?

Your code is broken.

ALAQUNAIBI wrote:
how can i solve that's problem ?

Fix the code.

xacc.ide - now with TabsToSpaces support
IronScheme - 1.0 alpha 4a out now (29 May 2008)

User 66582-Jul-08 3:55

User 6658

2-Jul-08 3:55

Fantastic, sometimes the solution can be so simple! Smile | :)

modified 12-Sep-18 21:01pm.

Pete O'Hanlon2-Jul-08 10:13

Pete O'Hanlon

2-Jul-08 10:13

leppie wrote:
ALAQUNAIBI wrote:
what is the problem?

Your code is broken.

ALAQUNAIBI wrote:
how can i solve that's problem ?

Fix the code.

That's real experience speaking there. Damn, you and your years of coping with subtle problems like this.

Deja View - the feeling that you've seen this post before.

My blog | My articles

Selection of Treeview node during page load

Simon P Stevens2-Jul-08 4:16

Simon P Stevens

2-Jul-08 4:16

1st read the error message, it will contain clues as to what you have done wrong.
2nd, Google for the error message, other people may have asked about it before so you might find clues.

3rd, when and only when you have done both of the above, if you are still stuck, post the full error message displayed, and the line of code that it says causes the error and we'll try to help.

Simon

shehezada2-Jul-08 1:03

shehezada

2-Jul-08 1:03

I have a treeview control whose particular node needs to be dynamically selected during page load. Kindly let me know the way to do this.

Re: Selection of Treeview node during page load

ajtunbridge2-Jul-08 2:33

Re: Selection of Treeview node during page load

2-Jul-08 2:33

TreeView treeView = new TreeView();
treeView.Nodes.Add("Monday");
treeView.Nodes.Add("Tuesday");

treeView.SelectedNode = treeView.Nodes[1];

Something like that anyway Smile | :)

This would select the "Tuesday" node.

shehezada2-Jul-08 22:19

shehezada

2-Jul-08 22:19

No this does not work. Thanks anyways.

The scenario is something like this.
1. On one page I have a tree view.
2. I select a node and add the node vale in a session variable.
3. On another page I have the treeview.
4. Here I fetch the session variable i.e. the selected node value.

Now I have to use this variable to automatically select the same node.

How to prevent user to go back to desktop?

bug_aonz2-Jul-08 0:58

bug_aonz

2-Jul-08 0:58

For some business reasons, i need my win form app run with fullscreen and not allow user to click any hot keys (such as windows button, alt+tab ,etc.) to go back to desktop or close the program.

is it possible to do this?
thank
^^

subai2-Jul-08 1:07

subai

2-Jul-08 1:07

i read somewhere that we have three ways of showing forms/dialogs (i did not remember exact text)
1- normal form.Show()
2- modal form.ShowDialog()
3-system modal ?

i don't know how to have system modal but it said that it will work for your purpose

I Wish the Life Had CTRL-Z
Wizard's First Rule : People are fool,they believe what they want to believe or what they afraid to believe
www.subaitech.blogspot.com

Simon P Stevens2-Jul-08 1:09

Simon P Stevens

2-Jul-08 1:09

No, it's not.

The user has, and always should have final control of their PC. There is no way to intercept the Ctrl+alt+del button press. Only the WinLogon process can receive notification of this key combo.

What is your reason for wanting to do this?

Simon

blackjack21502-Jul-08 3:41

blackjack2150

2-Jul-08 3:41

bug_aonz wrote:
For some business reasons...

Yeah, right. Am I the only one who smells malware?