|
Try giving us the latest version. Kind of hard to guess how you've rattled the box. 
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
void set_pixel(long x,long y, RGBTRIPLE colour){
image[(bmp.biHeight-1-y)*bmp.biWidth+x] = colour;
}
void get_pixel(int x, int y, RGBTRIPLE colour){
colour = image[(bmp.biHeight-1-y)*bmp.biWidth+x];
}
void clear_pixel(RGBTRIPLE colour){
colour.rgbtBlue = 0;
colour.rgbtGreen = 0;
colour.rgbtRed = 0;
}
void avg(RGBTRIPLE colour[], RGBTRIPLE merge, int size) {
unsigned int blue = 0, green = 0, red = 0;
for(int i=0; i<size; i++)="" {<br="" mode="hold" /> blue += colour[i].rgbtBlue;
green += colour[i].rgbtGreen;
red += colour[i].rgbtRed;
}
merge.rgbtBlue = blue / size;
merge.rgbtGreen= green / size;
merge.rgbtRed = red / size;
}
<small>
int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,
LPSTR lpCmdLine, int nCmdShow)
{
ZeroMemory (&bmp, sizeof bmp);
bmp.biClrImportant = 0;
bmp.biBitCount = 4;
bmp.biCompression = 0;
bmp.biPlanes = 1;
bmp.biSize = 40;
bmp.biSizeImage = 0;
bmp.biXPelsPerMeter = 0;
bmp.biYPelsPerMeter = 0;
bmp.biClrUsed = 16;
bmp.biHeight = 128;
bmp.biWidth = 128;
long paddedsize = bmp.biHeight * bmp.biWidth;
bfh.bfType = 19778;
bfh.bfReserved1 = 0;
bfh.bfReserved2 = 0;
bfh.bfOffBits = 1078;
bfh.bfSize = sizeof(BITMAPFILEHEADER) + sizeof(BITMAPINFOHEADER) + paddedsize;
hfile = CreateFile("noise.bmp",GENERIC_WRITE,FILE_SHARE_WRITE,NULL,OPEN_EXISTING,NULL,NULL);
ReadFile(hfile,&bfh,sizeof(bfh),&written,NULL);
ReadFile(hfile,&bmp,sizeof(bmp),&written,NULL);
int imagesize = bmp.biWidth*bmp.biHeight;
image = new RGBTRIPLE[imagesize];
ReadFile(hfile,image,sizeof(RGBTRIPLE),&written,NULL);</small>
RGBTRIPLE blank[9]= { 0 };
RGBTRIPLE Merge = { 0 , 0 , 0 };
long yp=0, xp=0;
for(int y = 0; y < bmp.biHeight; y=y+3){
for(int x = 0; x < bmp.biWidth; x=x+3){
for(int i = 0; i < 9; i++){
int yp=0, xp=0;
get_pixel(x+xp,y+yp,blank[i]);
if(xp<3)
xp++;
else{
xp = 0;
yp++;
} }
avg(blank, Merge, 9);
set_pixel(x,y,Merge);
for(int i = 0; i < 9; i++){
blank[i].rgbtBlue=0;
blank[i].rgbtGreen=0;
blank[i].rgbtRed=0;
}
clear_pixel(Merge);
yp=0, xp=0;
}}
EDIT: AHa! I've found something
for(int i = 0; i < 9; i++){
int yp=0, xp=0;
I declared yp and xp as int when I had already declared them as long. This was reverting them to 0 each time.
Trouble is, get_pixel() and set_pixel() give unhandled exceptions when they use anything other than x and y. I've tried "x=x+xp" but it still happens. Hmm....
I'm stumped.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Ok, a few more rookie gotchas. RGBTRIPLE is a struct. In get_pixel() and clear_pixel(), you want to operate on the pixel "colour" that you pass in. However, the way you've written it, you're working on a copy so you're changing nothing. You need to declare it as a pointer or a reference, RGBTRIPLE* pColour or RGBTRIPLE& colour. If you do it as a reference, you don't need to change the code inside the functions to pointer notation. The same thing applies to merge in avg(), you're working on a copy inside the function the passed parameter doesn't change.
I also don't think you're applying the kernel to your image properly. I'm not up on gaussian off the top of my head but you need to apply it to every pixel and its immediate neighbors so bumping the index of the loops by 3 each pass doesn't do it. Usually, applying a kernel you need a source image and then build a spearate destination image, otherwise you'd be using pixels you've already changed as you progress through.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
I've changed the code as you suggested, with a source and destination file. But I get in the output file is a black image with some very dark green lines going vertically across. :
Changed it a bit to use a 1,2,1, Matrix. This gives blue and green lines. Gah this is messed up.
2,4,2,
1,2,1
Here's the entire source... again.
#include "stdafx.h"
#include <windows.h>
#include <iostream>
HANDLE hfile;
HANDLE hfile2;
DWORD written;
BITMAPFILEHEADER bfh;
BITMAPINFOHEADER bmp;
RGBTRIPLE *image;
void set_pixel(long x,long y, RGBTRIPLE& colour){
image[bmp.biHeight+y*bmp.biWidth+x] = colour;
}
void get_pixel(int x, int y, RGBTRIPLE& colour){
colour = image[bmp.biHeight+y*bmp.biWidth+x];
}
void clear_pixel(RGBTRIPLE& colour){
colour.rgbtBlue = 0;
colour.rgbtGreen = 0;
colour.rgbtRed = 0;
}
void copy_pixel(RGBTRIPLE& colour, RGBTRIPLE& colour2){
colour.rgbtBlue = colour2.rgbtBlue;
colour.rgbtGreen = colour2.rgbtGreen;
colour.rgbtRed = colour2.rgbtRed;
}
void avg(RGBTRIPLE colour[], RGBTRIPLE& merge, int size, BYTE Matrix[]) {
unsigned int blue = 0, green = 0, red = 0;
for(int i=0; i<size; i++)="" {<br="" mode="hold" /> blue += colour[i].rgbtBlue * Matrix[i] / 16;
green += colour[i].rgbtGreen * Matrix[i] / 16;
red += colour[i].rgbtRed * Matrix[i] / 16;
}
merge.rgbtBlue = blue / size;
merge.rgbtGreen= green / size;
merge.rgbtRed = red / size;
}
BYTE Matrix[9] = { 1, 2, 1,
2, 4, 2,
1, 2, 1 };
int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,
LPSTR lpCmdLine, int nCmdShow)
{
ZeroMemory (&bmp, sizeof bmp);
bmp.biClrImportant = 0;
bmp.biBitCount = 8;
bmp.biCompression = 0;
bmp.biPlanes = 1;
bmp.biSize = 40;
bmp.biSizeImage = 0;
bmp.biXPelsPerMeter = 0;
bmp.biYPelsPerMeter = 0;
bmp.biClrUsed = 0;
bmp.biHeight = 128;
bmp.biWidth = 128;
long paddedsize = bmp.biHeight * bmp.biWidth;
bfh.bfType = 19778;
bfh.bfReserved1 = 0;
bfh.bfReserved2 = 0;
bfh.bfOffBits = 1078;
bfh.bfSize = sizeof(BITMAPFILEHEADER) + sizeof(BITMAPINFOHEADER) + paddedsize;
hfile = CreateFile("noisein.bmp",GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,NULL,NULL);
hfile2 = CreateFile("noiseout.bmp",GENERIC_WRITE,FILE_SHARE_WRITE,NULL,OPEN_EXISTING,NULL,NULL);
ReadFile(hfile,&bfh,sizeof(bfh),&written,NULL);
ReadFile(hfile,&bmp,sizeof(bmp),&written,NULL);
ReadFile(hfile2,&bfh,sizeof(bfh),&written,NULL);
ReadFile(hfile2,&bmp,sizeof(bmp),&written,NULL);
int imagesize = bmp.biWidth*bmp.biHeight;
image = new RGBTRIPLE[imagesize];
ReadFile(hfile ,image,sizeof(RGBTRIPLE),&written,NULL);
ReadFile(hfile2,image,sizeof(RGBTRIPLE),&written,NULL);
RGBTRIPLE blank[9]= { 0 };
RGBTRIPLE Merge = { 0 , 0 , 0 };
int yp=0, xp=0;
for(int y = 1; y < bmp.biHeight; y++){
for(int x = 1; x < bmp.biWidth; x++){
for(int i = 0; i < 9; i++){
{
get_pixel(x+xp,y+yp,blank[i]);
if(xp<3)
xp++;
else{
xp = 0;
yp++;}
}
}
avg(blank, Merge, 9, Matrix);
set_pixel(x,y,Merge);
clear_pixel(Merge);
yp=0, xp=0;
}}
WriteFile ( hfile2, &bfh, sizeof(bfh), &bfh.bfSize, NULL );
WriteFile ( hfile2, &bmp, sizeof(bmp), &bfh.bfSize, NULL );
WriteFile ( hfile2, image, paddedsize, &bfh.bfSize, NULL );
CloseHandle(hfile);
}</iostream></windows.h>
"Sir, I protest. I am NOT a merry man!"
modified on Monday, June 9, 2008 12:00 PM
|
|
|
|
|
Ok, you have two files now but you only still have one bitmap in memory, especially the image variable. You're reading from it, operating on the pixels, and writing them back in place. You read the first file into memory and immediately read over the data in memory from the second. Not good.
If you're going to use a global for the pixel matrix, get_pixel would have to work on the original image and set_pixel on the output image. A better way would be to write general functions that have a pointer to the pixel matrix as a parameter, then you'd be set.
The other thing that has jarred my consciousness is the calcualtion of the index when you're accessing a pixel in image, ie "image[bmp.biHeight+y*bmp.biWidth+x]". Why the offset "bmp.biHeight"? Shouldn't the index to the pixel just be "y*bmp.biWidth+x"?
Hard to tell some of this since for some reason your for loops don't seem to copy well. Are you using tabs in your code rather than spaces? Anyhow, it looks like you're closing in on doing the loop ranges on row and column properly from how I remember kernels. The starting index being one, however, you need to subtract 1 from the end test or you'll run off the edge. More properly, you have to allow a border of KernelSize/2 around the edge of your image since you can't really apply a kernel to those pixels. I'm not sure the stuff in the middle is correct but it's hard to make out. You're going to force me to actually look up Gaussian blur. 
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
That's the saddest face I've ever seen. I'll get right onto fixing those things. If it works, thanks for the advice.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
|
Ok, a few things for you to think about while I'm trying to figure out your pixel indexing scheme. You read the second file, the output file, into memory. Why? You simply want to calculate the new image and write it?
You never free the memory you allocated for the two image arrays. Won't kill you in this instance but bad practice.
It doesn't look like you close the output file before you exit. I think Windows will do this for you but I never trust Windows to do anything I can do explicitly. It saves big teeth marks in your ass if it doesn't actually do what it's advertised to do. I'll get back to you on the rest of it.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Ok, courtesy of Wikipedia I've brushed up on Gaussian blurring.  You're trying to replace each pixel, well at last those not on an edge with a weighted average of itself and the 8 pixels surrounding it. You have your weights in the array and are multiplying the pixel by the weight and diving by the sum of the weights (16). Two things. First and most glaring is why do you divide the blurred values by "size", 9 on your case? That's going to make things dark as you just cut each pixel value to 1/9 of its value, something less than 23 maximum out of the possible 255 if I did that right. Second, you'd be more accurate to do the division after you've fully accumulated the 9 weighted pixel values. The way you have it, you get a little truncation for each of the 9. If you wait until the end, you only get the truncation once. So get rid of the division by 16 in the loop and replace "size" by 16 at the end.
Now to figure out how you're getting the 9 pixels to average. All I know for sure is that I'm 99.9% sure what you're doing isn't right. 
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Well, this those changes, it now comes out red and black instead of grey and black.
I'm Sure I'm doing it wrong too.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
If the colors are changing, then what you're doing wrong is your pixel lookup, the colors are bleeding between red, green and blue. Did you read my article which has a guassian blur filter in it ?
Christian Graus
Please read this if you don't understand the answer I've given you
"also I don't think "TranslateOneToTwoBillion OneHundredAndFortySevenMillion FourHundredAndEightyThreeThousand SixHundredAndFortySeven()" is a very good choice for a function name" - SpacixOne ( offering help to someone who really needed it ) ( spaces added for the benefit of people running at < 1280x1024 )
|
|
|
|
|
Yes, I did.
However, I don't see how my pixel lookup is wrong. :S
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Ok, for starters I believe you're scanning the input image correctly now, x and y cover the correct pixels. However, you want to grab 3 pixels from the previous row right above the target pixel, three from the current row including the two on either side of the target, and the from the next row. So xp and yp have to take the values, [-1, 0, 1]. You start with 0 and your test of xp < 4 actually makes xp go from 0, 1, 2, 3. So you're getting the wrong pixel correlated.
Also, after you call avg(), you should only be setting 1 pixel in the output image, the one at x, y. So the second set of for loops need to vanish.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Thanks for the advice  . But now, the output is just red and black lines 
Here's the updated code:
unsigned int yp=0, xp=0;
for(int y = 1; y < bmp.biHeight-1; y++){
for(int x = 1; x < bmp.biWidth-1; x++){
for(int i = 0; i < 9; i++){
{
get_pixel(x+xp,y+yp,blank[i],image);
if(xp<2)
xp++;
else{
xp = -1;
yp++;}
}
}
avg(blank, Merge, 9, Matrix);
set_pixel(x,y,Merge,image2);
clear_pixel(Merge);
yp=-1, xp=-1;
}}
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Well, this is sure messy.
Apart from anything else, all these function calls are going to slow your code down. avg works on a reference, it doesn't return a value ?
yp and xp are zero at the start of the first loop, every other time they start at -1. I'm sure that's not the only issue, but it's an indication of the sort of problems you probably have.
Christian Graus
Please read this if you don't understand the answer I've given you
"also I don't think "TranslateOneToTwoBillion OneHundredAndFortySevenMillion FourHundredAndEightyThreeThousand SixHundredAndFortySeven()" is a very good choice for a function name" - SpacixOne ( offering help to someone who really needed it ) ( spaces added for the benefit of people running at < 1280x1024 )
|
|
|
|
|
Christian is right about the initialization of xp and yp. And the xp<2 test is wrong. It's short, count it out in your fingers. 
He's right about it being very messy and inefficient. But right now it's more important for you to understand the algorithm.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Oh, one other question. You apparently assume that the pixels are RGB triples. You never check the bitmap info to make sure it matches. Were you told this is the structure of the image?
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Yeah, I spotted that, too. But, I assume it is, if it were 32 bit, he'd be complaining about pixels not processed, I reckon.
Christian Graus
Please read this if you don't understand the answer I've given you
"also I don't think "TranslateOneToTwoBillion OneHundredAndFortySevenMillion FourHundredAndEightyThreeThousand SixHundredAndFortySeven()" is a very good choice for a function name" - SpacixOne ( offering help to someone who really needed it ) ( spaces added for the benefit of people running at < 1280x1024 )
|
|
|
|
|
I spotted the initialisation of xp and yp straight after posting. But it had no effect. 
I wasn't aware you could check if it was an RGBTRIPLE. Ignorance, I guess. How would I go about this? However, the other program I am using to create the random noise input image seems to work fine with the same values in the header BITMAPINFOHEADER and BITMAPFILEHEADERs.
Oh, and, rather ironically, I used so many function calls to try and clean the for loops up. 
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Have you tried stepping through your code in the debugger to see if things actually work like you're expecting them to? I would have been doing that about 14 messages ago.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Hmm....
xp is set to 4294967295 and does not change with each loop... y, however, does as is wanted.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Okay, fixed that. Still get the same output, though.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Hmm.... I tried recreating the file using the other program(which uses the same values in bmp and bfh) using the CREATE_NEW definition in the CreateFile() function. When I do this, the resulting image cannot be drawn by windows picture and fax viewer. This may be the problem...
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Sounds like a clue to me.  I'm not really up on that kind of file I/O. I rarely store things these days.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
You've gone quiet. Did you ever get it to work? Inquiring minds want to know.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
