Re: can not delete a file - C / C++ / MFC Discussion Boards

SandipG 30-Jul-07 1:14

30-Jul-07 1:14

I think it happens because FindFile Handle i.e. hFind is open.
I have faced similar issue with CFileFind.Try to delete after you close the handle.

Re: can not delete a file

George_George30-Jul-07 2:39

George_George

30-Jul-07 2:39

Hi SandipG,

I have tried that it does not matter.

regards,
George

Re: can not delete a file

Don Box30-Jul-07 2:17

Don Box

30-Jul-07 2:17

Hello George_George, I'll tell u the exact problem u r having and how to rectify it.

Your Code:-------------------------------------------------

int remove_non_empty_directory (const char* path)<br />
{<br />
<br />
WIN32_FIND_DATA FindFileData;<br />
HANDLE hFind;<br />
int rtn;<br />
<br />
hFind = FindFirstFile(path, &FindFileData);<br />
if (hFind == INVALID_HANDLE_VALUE)<br />
{<br />
FindClose(hFind);<br />
return -1;<br />
}<br />
else<br />
{<br />
// delete 1st file<br />
rtn = <pre>DeleteFile(&(FindFileData.cFileName));</pre><br />
<code>if (0 == rtn)<br />
{<br />
ErrorExit (NULL);<br />
}<br />
<br />
// List all the other files in the directory and delete all files<br />
while (FindNextFile(hFind, &FindFileData) != 0)<br />
{<br />
rtn = <pre>DeleteFile(&(FindFileData.cFileName));</pre><br />
<code>}<br />
<br />
FindClose(hFind);<br />
}

----------------------------------------------------------
The problem lies in the highlighted lines. FindFileData.cFileName contains only the FILE NAME, NOT PATH. So the problem. Rectify it by replacing the highlighted lines by DeleteFile(path);

Come online at:-
jubinc@skype

Re: can not delete a file

Jonathan [Darka]30-Jul-07 2:29

Jonathan [Darka]

30-Jul-07 2:29

Don Box wrote:
Rectify it by replacing the highlighted lines by DeleteFile(path);

That won't work as he is most likely passing in just a folder name, or a folder name with a wildcard attached.

He should take the original path (excluding wildcard) and then add the filename from FindFileData.cFileName and then Delete that.

regards,

Jonathan Wilkes
Darka[Xanya.net]

Re: can not delete a file

George_George30-Jul-07 2:41

George_George

30-Jul-07 2:41

You are always right, Jonathan!

regards,
George

Re: can not delete a file

Jonathan [Darka]30-Jul-07 2:52

Jonathan [Darka]

30-Jul-07 2:52

George_George wrote:
You are always right, Jonathan!

Only most of the time Wink | ;-)

best wishes,

Jonathan Wilkes
Darka[Xanya.net]

Re: can not delete a file

George_George30-Jul-07 2:40

George_George

30-Jul-07 2:40

Thanks Don!

It works! Cool!

regards,
George

Re: can not delete a file

Bryster30-Jul-07 2:19

Bryster

30-Jul-07 2:19

Hi I was just looking at your problem and why not try someting completely different.

You could create a batch file which deletes the files within a folder.

1. Create a new text file for writing to (say on your c:\) with the extension of ".BAT"
2. Write to that file the path of the directory you want to delete, fprintf(cfile,"del %s\*.*",pathname)
3. Close the file
4. Using the SPOOL command run the file.

Just a quick solution to your problem.

Bry. Big Grin | :-D

Re: can not delete a file

George_George30-Jul-07 2:44

George_George

30-Jul-07 2:44

Thanks Bryster,

I need to implement through Windows API to be more efficient. Smile | :)

regards,
George

Re: can not delete a file

gvisgr830-Jul-07 2:19

gvisgr8

30-Jul-07 2:19

Are you sure that those files are not read only.
As once i wasalso facing the same problem but after checking out read only attribute. it was working fine...

Who am I?
Do you know me.... OMG | :OMG:

Re: can not delete a file

David Crow30-Jul-07 3:32

David Crow

30-Jul-07 3:32

George_George wrote:
I am using the following program to delete all files in a specified directory.

Why not just use SHFileOperation()?

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: can not delete a file

George_George30-Jul-07 2:44

George_George

30-Jul-07 2:44

Sure, gvisgr8. I have enough privilege.

regards,
George

Re: can not delete a file

George_George30-Jul-07 4:11

George_George

30-Jul-07 4:11

Because I suspect on Windows Mobile it is not supported -- I need to write program for both Windows desktop and Window CE.

regards,
George

Re: can not delete a file

David Crow30-Jul-07 3:49

David Crow

30-Jul-07 3:49

George_George wrote:
Sure, gvisgr8.

I'm not gvisgr8.

George_George wrote:
I have enough privilege.

I was not concerned with privileges. I was simply suggesting replacing dozens of lines of code with a single one.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: can not delete a file

George_George30-Jul-07 4:12

George_George

30-Jul-07 4:12

How?

DavidCrow wrote:
I was simply suggesting replacing dozens of lines of code with a single one.

regards,
George

Re: can not delete a file

David Crow30-Jul-07 4:46

David Crow

30-Jul-07 4:46

George_George wrote:
How?

By using SHFileOperation() instead.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: can not delete a file

George_George30-Jul-07 16:46

George_George

30-Jul-07 16:46

Thanks DavidCrow,

This function is convenient to use, but I am not sure whether we can use it on Windows CE.

regards,
George

getline()

garfaoui30-Jul-07 0:09

garfaoui

30-Jul-07 0:09

Hello,
I am using the command getline() to get the line of a text file.. But i think i have a problem with this command.
Here is how i used it in my programme:
getline(list,s1);
list is

fstream list;<br />
list.open("listfile.txt",ios::in);

and s1 is string s1;
The included libraries of my programme are :

#include <cstdlib><br />
#include <iostream><br />
using namespace std;<br />
#include<fstream><br />
#include<stdio.h>  <br />
#include <time.h><br />
#include <sstream><br />
#include<string>

I was wondering if getline() had a limit of character by line, and if it is so, how can i know its limit and change it.
Thank you

Re: getline()

Nelek30-Jul-07 0:22

Nelek

30-Jul-07 0:22

I am not sure at 100% but I think the getline () works buffering, so it is supposed to get the text until it founds an "\n" to change line.

About your includes... write the lines with a space between "<" and ">" I mean... you have to write i.e. #include < math.h > because if not, the web trys to use it as < pre > and so on...

Greetings.

--------
M.D.V.

If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?

Re: getline()

garfaoui30-Jul-07 0:25

garfaoui

30-Jul-07 0:25

ok thank you very much for this answer.
Big Grin | :-D

Re: getline()

David Crow30-Jul-07 3:34

David Crow

30-Jul-07 3:34

garfaoui wrote:
#include
#include
using namespace std;
#include
#include
#include
#include
#include

Is it so hard to go back and preview your post to make sure it reads exactly as you expect?

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: getline()

garfaoui30-Jul-07 3:39

garfaoui

30-Jul-07 3:39

hum ...

Re: getline()

David Crow30-Jul-07 3:47

David Crow

30-Jul-07 3:47

The Preview button works regardless of whether you are humming or singing.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: getline()

garfaoui30-Jul-07 4:02

garfaoui

30-Jul-07 4:02

OKKKKKKKKK....
i didnt know that such a button exist... sorryyyyyyyyy
what should i do kneeing at your foot? i apologise, it s not enough? D'Oh! | :doh:

Re: getline()

David Crow30-Jul-07 4:45

David Crow

30-Jul-07 4:45

garfaoui wrote:
i didnt know that such a button exist... sorryyyyyyyyy

It's right next to the Post Message button.

garfaoui wrote:
what should i do kneeing at your foot? i apologise, it s not enough?

Sarcasm and apologies are not necessary. I was merely letting you know a way of increasing your chances of receiving help.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.