|
ewwww!
Declare the variables as close to their first use as possible.
I have spoken.
cheers,
Chris Maunder
CodeProject.com : C++ MVP
|
|
|
|
|
Well I started programming in Java and we were told to put all our declarations up the top (which i think is the Java coding standard), and i like it this way. Makes all your declarations easy to find.
However, sometimes i need a variable at that scope which will only be used further down, so i put it there. It all comes down to the scope of you're variable and where it's used in that scope as to where it should go
Customer in computer shop: "Can you copy the Internet onto this disk for me?"
|
|
|
|
|
Actualy it arose from some code i wrote in .Net.
I wrapped a generic HttpSession collection in something that exposed typed properties for each of the items it contained, And was told it was a total waste of my time.
T
-------------------------------
Carrier Bags - 21st Century Tumbleweed.
|
|
|
|
|
Tristan Rhodes wrote: And was told it was a total waste of my time.
Why?
CleaKO
"I think you'll be okay here, they have a thin candy shell. 'Surprised you didn't know that.'" - Tommy (Tommy Boy)
"Fill it up again! Fill it up again! Once it hits your lips, it's so good!" - Frank the Tank (Old School)
|
|
|
|
|
Because the general concencus was that "It's the most pointless piece of code" they had ever seen.
:S
-------------------------------
Carrier Bags - 21st Century Tumbleweed.
|
|
|
|
|
I'd have to see the code.
|
|
|
|
|
<br />
public class SessionWrapper<br />
{<br />
<br />
private HttpSessionState session;<br />
<br />
<br />
public SessionWrapper()<br />
{<br />
session = HttpContext.Current.Session;<br />
}<br />
<br />
public string UserName<br />
{<br />
get{return (string)session[SE_USER_NAME];}<br />
set{session[SE_USER_NAME] = value;}<br />
}<br />
<br />
public int? LastPurchase<br />
{<br />
get{return (int?)session[SE_LAST_PURCHASE];}<br />
set{session[SE_LAST_PURCHASE] = value;}<br />
}<br />
<br />
<br />
}<br />
<br />
I'm actualy working on a code generator to build stuff like that for me, but at the time it was written manualy.
My argument was its a strongly typed wrapper that exposes other developers to exactly what they need, what type it is, and hides the constants.
T
-------------------------------
Carrier Bags - 21st Century Tumbleweed.
|
|
|
|
|
Makes sense to me.
A similar thing I do is with ExecuteScalar(), which returns object which then (usually) requires a test for null and a cast, and setting a default value if null. I wrote a wrapper like public virtual T ExecuteScalar<T>(T IfNull){...} to handle the cast. Any time I'm writing a scalar query and don't have to test for null and/or do a cast I save time, the code is more readable too.
Usually, spending the time to encapsulate such common tasks will pay off.
"A stitch in time saves nine."
|
|
|
|
|
Well i spent a few months crusading for sensible coding practices, and now i've given up. The other day i was told to remove it, re-centralise all the constants and simply use Session[AppConstants.CONST_NAME] to access everything.
-------------------------------
Carrier Bags - 21st Century Tumbleweed.
|
|
|
|
|
Glad I'm in a small IT department and have free reign on what I write.
|
|
|
|
|
I'm in a small IT department too, that was the CTO and Senior Developer pulling rank on my design decision. :S
(I'm leaving in a week anyway  )
T
-------------------------------
Carrier Bags - 21st Century Tumbleweed.
|
|
|
|
|
I just spent the day (working from home) writing a wrapper for NumericUpDown that is generic and will take any of the built-in numerics, hide the actual decimal, and handle the casting so I don't have to.
Ugly as Hillary, but it works.
|
|
|
|
|
Maybe it was just the code.
Strong typing is a good way to control up front what type of information you are looking for rather than waiting for it to hit the database or a flat file and finding out later it isnt what it should be.
CleaKO
"I think you'll be okay here, they have a thin candy shell. 'Surprised you didn't know that.'" - Tommy (Tommy Boy)
"Fill it up again! Fill it up again! Once it hits your lips, it's so good!" - Frank the Tank (Old School)
|
|
|
|
|
|
While converting an existing internal application from vb6 to c# i came accross the following :
'Reusable code -- Cut from here --
do some work here
'Reusable code -- Cut to here --
So you can guess what happens when you change something in that code block 
http://sourceforge.net/projects/banshee32
|
|
|
|
|
Ummm... no? I'm guessing either nothing or something catastrophic.
|
|
|
|
|
PIEBALDconsult wrote: something catastrophic
Yes if you don't copy&paste modifications of that so called "reusable" code to all places where it was "reused".
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus
"Real men use mspaint for writing code and notepad for designing graphics." - Anna-Jayne Metcalfe
|
|
|
|
|
Ah! A Visual Studio Code snippet!
|
|
|
|
|
Ah, now that makes sense... kinda.
|
|
|
|
|
Some of those "snippets" were indeed pasted all over the place ... Imagine my surprise when the original author could not understand why his updates didnt work like it should
|
|
|
|
|
Maybe he should use the "C preprocessor" with his BASIC code.
|
|
|
|
|
Very nice resusable code
Regards,
Sylvester G
sylvester_g_m@yahoo.com
|
|
|
|
|
If txtProvCt.Text = txtProvCtS Then
Else
giUpdate = True
End If
|
|
|
|
|
and not unusual...
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
|
|
|
|
|
CPallini wrote: and not unusual...
Queue the Tom Jones soundtrack.
Deja View - the feeling that you've seen this post before.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
