|
We prefer the following because it has got more readability than the other
if(...)
{
...
}
else
{
...
}
Rinu Raj
|
|
|
|
|
Both the ways. It's just upto you what you feel better to work with. IMO the first option offers more readabilty and indentation for your code is also very clear. So I prefer to go with the first option.
Somethings seem HARD to do, until we know how to do them.
 _AnShUmAn_
|
|
|
|
|
The first one! Easier on the eyes.
|
|
|
|
|
I've never seen variation 2, although I see a lot of
if {
}
else{
}
Either way, my vote is for 1.
Christian Graus - Microsoft MVP - C++
Metal Musings - Rex and my new metal blog
|
|
|
|
|
I prefer the first; it's easier to identify scope with brackets that line up. It also puts some white space between the if (or other leading statements) and code inside the scope. (I also tend to put a blank line before the if.)
Anyone who thinks he has a better idea of what's good for people than people do is a swine.
- P.J. O'Rourke
|
|
|
|
|
Hi everybody!
I'm developing an App by MFC , I create a dialog open file from class CFileDialog enable user choose image file to open,and I want default property view in menu views of CFileDialog always is Icon,(default it is List).
Thanks for any help!
|
|
|
|
|
toanmtkh@yahoo.com wrote: create a dialog open file from class CFileDialog enable user choose image file to open,and I want default property view in menu views of CFileDialog always is Icon,(default it is List).
CFileDialog gets its view selection from Explorer. So however Explorer is set to view a director is how CFileDialog should. Quick search of MSDN doesn't revile any hints at modifying the default behavior. However this is code project and someone has already gone through the trouble of modifying CFileDialog for your needs A class based on CFileDialog that provides easy image preview[^]. Good luck 
I'd love to help, but unfortunatley I have prior commitments monitoring the length of my grass. :Andrew Bleakley:
|
|
|
|
|
Hi all,
Here is what I'm trying to do. I write a windowless application running in the background. I want to detect every call to CreateWindowEx. Basically, if any other application is trying to create a window that pops up on top of the active window, I want to move it behind the active window, not suppressing it like thouse popup blocker though. I read about it in MSDN and I think I can use SetWindowsHookEx to detect HCBT_CREATEWND. According to the documentation, I need to place the CBTProc function inside a dll. I've followed the steps but it still can't seem to detect HCBT_CREATEWND when other applications create a window. However, it can if the window is created by my own application. Am I missing something?
This is what I have in my application code:
dllModule = LoadLibrary(_T("My.dll"));
if (dllModule)
{
CBTProcPtr = (HOOKPROC) GetProcAddress(dllModule, "CBTProc");
if (CBTProcPtr)
g_hHook = ::SetWindowsHookEx(WH_CBT, CBTProcPtr, dllModule, 0);
}
This is what I have in my dll code:
#include "stdafx.h"
#include <TCHAR.H>
#include "strsafe.h"
BOOL APIENTRY DllMain( HMODULE hModule,
DWORD ul_reason_for_call,
LPVOID lpReserved
)
{
return TRUE;
}
LRESULT CALLBACK CBTProc(int nCode, WPARAM wParam, LPARAM lParam)
{
TCHAR tempStr[1028] = {0};
_stprintf_s(tempStr, _T("Inside CBTProc. nCode: %d\n"), nCode);
OutputDebugString(tempStr);
if (nCode == HCBT_CREATEWND)
{
OutputDebugString(L"Inside HCBT_CREATEWND\n");
CBT_CREATEWND* wndData = (CBT_CREATEWND*)lParam;
if (wndData && wndData->lpcs)
{
OutputDebugString(wndData->lpcs->lpszName);
OutputDebugString(wndData->lpcs->lpszClass);
}
}
return ::CallNextHookEx(0, nCode, wParam, lParam);
}
|
|
|
|
|
AFAIK, Your process of setting up the hook, Forwarding calls to the window(HOOK) procedure and then releasing the hook should be performed inside the dll. The messages are then captured by the dll before they are passed on to any application.
Somethings seem HARD to do, until we know how to do them.
_AnShUmAn_
|
|
|
|
|
Hm... no luck with that either. I added this code to my dll.
void APIENTRY StartHook()
{
if (!gHinstance)
return;
g_hHook = SetWindowsHookEx(WH_CBT, CBTProc, gHinstance, 0);
return;
}
void APIENTRY StopHook()
{
if (g_hHook)
UnhookWindowsHookEx(g_hHook);
}
This to my application
if (dllModule)
{
StartHookProcPtr = (VOIDPROC) GetProcAddress(dllModule, "StartHook");
(StartHookProc)();
}
|
|
|
|
|
When you use global hooks you are effectively writing a distributed application. The calls to OutputDebugString are being called in the context of the application which creates the window ***NOT*** the process which installs the hook - this is the nature of global hooks and why they're so dangerous to overall system stability if written incorrectly. In short, your code may be working but you're looking in the wrong place for the debug messages.
Steve
|
|
|
|
|
You may vote me down but if the calls to OutputDebugString are replaced with calls to something like MessageBeep you may find I'm correct.
Steve
|
|
|
|
|
Replace the calls to OutputDebugString with MessageBeep(-1) and make sure your sound is turned up. Before you do this make sure that MessageBeep(-1) produces an audible beep in a stand-alone program. Do you hear a beep when a window is created in another process?
Steve
|
|
|
|
|
Hi Steve,
Yo Da Man! Yes, it does beep like crazy when I replaced OutputDebugString with MessageBeep.
Thanks so much for the help!
|
|
|
|
|
|
Strange thing. When my hook function is invoked and I try to access the lpszClass value, it will crash the application if it's hooked to its thread id, or visual studio, explorer and everything else (I have to reboot the computer...) if I specify 0 as the thread id in SetWindowsHookEx
I just need to detect if the window class is of a specific name. If I comment out the _tcsstr line the crash will go away, but then I can't detect the specific window. I vaguely remember seeing a bad pointer value in the debugger, but I'm already checking the pointer before using it. Could it be some windows are not initialized properly?
LRESULT CALLBACK CBTProc(int nCode, WPARAM wParam, LPARAM lParam)
{
if (nCode == HCBT_CREATEWND)
{
CBT_CREATEWND* wndData = (CBT_CREATEWND*)lParam;
if (wndData && wndData->lpcs)
{
if (wndData->lpcs->lpszClass)
{
if (_tcsstr(wndData->lpcs->lpszClass, _T("the window class name")))
{
}
}
}
}
return ::CallNextHookEx(0, nCode, wParam, lParam);
}
|
|
|
|
|
jipai wrote: LRESULT CALLBACK CBTProc(int nCode, WPARAM wParam, LPARAM lParam)
have u exported the above function?
nave
|
|
|
|
|
Yup.
LIBRARY "My"
EXPORTS
; Explicit exports can go here
StartHook
StopHook
CBTProc
|
|
|
|
|
See Hooks[^] maybe it is some helpful to you
|
|
|
|
|
Thanks for the info. Good to know.
|
|
|
|
|
I hope it solve your problem
|
|
|
|
|
I have created a MFC project in Visual C++ .NET. My goal is read in what is coming from COM port 4.
Here is the entire function below with some comments on what happens:
<br />
BOOL CReadComDlg::ConfigureCOMPort()<br />
{<br />
CString strPort;<br />
BOOL fSuccess;<br />
iCOMPortNumber = 4;
<br />
strPort.Format("COM%d", iCOMPortNumber) ;<br />
<br />
m_hFile = CreateFile( strPort, <br />
GENERIC_READ | GENERIC_WRITE,<br />
(DWORD)NULL,
NULL,
OPEN_EXISTING,<br />
FILE_ATTRIBUTE_NORMAL,<br />
NULL );
<br />
if (INVALID_HANDLE_VALUE == m_hFile)<br />
{<br />
AfxMessageBox( "ERROR 2: unable to connect to COM port." );<br />
return FALSE;<br />
}<br />
<br />
<br />
SetupComm( m_hFile,
(DWORD)2048,
(DWORD)2048);
<br />
<br />
DCB dcb;<br />
fSuccess = GetCommState(m_hFile,&dcb);<br />
<br />
if (!fSuccess) <br />
{<br />
DWORD dError = GetLastError();<br />
<br />
AfxMessageBox ("Error 3: Failed to Get the System Communication Settings.", MB_OK|MB_ICONEXCLAMATION );<br />
return FALSE;<br />
}<br />
.<br />
.<br />
.<br />
.<br />
}<br />
Both functions return error code 995: ERROR_OPERATION_ABORTED = The I/O operation has been aborted because of either a thread exit or an application request.
What does this mean? What am i doing wrong? When I use hyperterminal to setup the connection it works fine. I want to be able to receive data from the COM port. I don't even want to send anything out to the COM port.
If anyone has any suggestions, helpful links, or sample code that would be very helpful. Thank you for your time.
|
|
|
|
|
Hello!
I've made a simple application. When I click a button in mian window a modal popup window shows up:
Ustawienia modalne;
modalne.DoModal();
I want that when I click OK in this modal wnd. it changes a Static Text in main wnd.:
void Modalne::OnBnClickedOk()
{
UpdateData(true);
((CNoweOknoDlg*)m_pParent)->m_text1 = "tekst";
((CNoweOknoDlg*)m_pParent)->UpdateData(false);
OnOK();
}
When I press this button the app crasches 
When I made this popup wnd. as modeless using Create() funtion everything is OK. :/
|
|
|
|
|
You should expose the string on your dialog and set the text in your main window. Apart from anything else, your approach makes the two forms tightly coupled for no good reason.
Christian Graus - Microsoft MVP - C++
Metal Musings - Rex and my new metal blog
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
