|
samflex wrote: YourApp.exe site1.local codeproject.com google.com
That's correct, if your compiled application is YourApp.exe , and you want to test three domains - site1.local , codeproject.com , and google.com .
Obviously you'd need to use your real .exe name there, and pass in the actual domains / servers you wanted to test.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Oh ok. I was confused by site1 thinking it was meant to be site as per the argument in ServerStatusBy() method.
Thank God my demo pushed to 1:30pm so i can test this to see what happens.
Thank you so much.
I can't say this enough.
|
|
|
|
|
I have run into a little problem here.
Console app, at least the one I am building and compiling is not generating an .exe file.
For instance, the project name is showserverstatus.
When I go into the bin folder, debug, I see showserverstatus.dll but not .exe
As a result, I am having problem testing the app.
Any ideas sir?
|
|
|
|
|
Looks like you've created a .NET Core / .NET 5 application. You would need to publish the application to generate an exe file:
Build .NET Core console application to output an EXE - Stack Overflow[^]
Otherwise, you would need run it using the dotnet command:
dotnet showserverstatus.dll site1 site2 ...
Or you could change the target framework to net472 to generate a .NET Framework exe instead. Double-click on the project file, find the line that looks like:
<TargetFramework>net5.0<TargetFramework> and change it to:
<TargetFramework>net472</TargetFramework> Target frameworks in SDK-style projects - .NET | Microsoft Docs[^]
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Sorry for all the trouble sir.
Please hang in there with me a little longer if you can.
I chose the path of least resistance by publishing and like you correctly stated, it generated .exe file.
I tried testing and ran into an error.
Please see how I was testing and the error:
C:\inetpub\wwwroot\showserverstatus\bin\publish>showserverstatus.exe google.com
IP Address: 2607:f8b0:4000:819::200e
RoundTrip time: 44
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
at showserverstatus.Program.ServerStatusBy(String site) in C:\inetpub\wwwroot\showserverstatus\Program.cs:line 41
at showserverstatus.Program.Main(String[] args) in C:\inetpub\wwwroot\showserverstatus\Program.cs:line 16
As you can see, it displayed status of two lines before the error.
This is line 16:
foreach (string site in args)
and this is line 41:
Console.WriteLine("Time to live: {0}", reply.Options.Ttl);
UPDATE:
My demo went well for the mere fact that this app actually ran and sent email was considered a success even though the email did not contain anything.
Here is why.
Due to the error I was getting that I posted above, I removed all of those reply.stuff and then just left only DOWN or WORKING.
They wanted them worded as those.
Per the changes I made below, the app ran and sent the email but when I received the email, there was no message that site is WORKING or DOWN.
Is it because of the changes by replacing Subject with hardcoded values and body with hardcoded values?
They also brought up something that I overlooked.
They wanted Subject to read: Server Status
They wanted the body to read:
Please find the status of the DMZ servers below:
whatever site name is - working or Down (Whatever the status is).
This is latest code.
Please, please forgive me sir for all these troubles. Looks like we are almost there.
I changed the code below to format them just as described above.
The only issue now and it is a big one is that it works with pretty much any URL I tested with except anything that begins with gis.
For instance, none of these worked:
https://gis.massdot.state.ma.us/arcgis/rest
gis.massdot.state.ma.us/arcgis/rest/
gis.massdot.state.ma.us/arcgis/rest
using System;
using System.IO;
using System.Net;
using System.Net.Mail;
using System.Net.NetworkInformation;
using System.Text;
using System.Configuration;
using System.Collections.Generic;
namespace showserverstatus
{
class Program
{
static void Main(string[] args)
{
var siteToStatus = new Dictionary<string, string>();
foreach (var site in args)
{
var reply = new Ping().Send(site, 10000);
siteToStatus[site] = (reply.Status == IPStatus.Success) ? "UP" : "DOWN";
}
var subject = "Server Status";
var body = "Please find the status of the servers below:";
foreach (var kvp in siteToStatus)
{
body += $"{Environment.NewLine}{kvp.Key}: {kvp.Value}";
}
SendEmail(subject, body);
}
static bool ServerStatusBy(string site)
{
Ping pingSender = new();
PingReply reply = pingSender.Send(site, 10000);
if (reply.Status != IPStatus.Success)
{
SendEmail($"{site} DOWN", $"Ping {site}");
return false;
}
SendEmail($"{site} WORKING", $@"Ping {site}");
return true;
}
public static void SendEmail(string subject, string body)
{
using MailMessage mm = new(ConfigurationManager.AppSettings["FromEmail"], "joeblow@yahoo.com");
mm.To.Add("johndoe@gmail.com");
mm.CC.Add("joesixpack@yahoo.com");
mm.Subject = subject;
mm.Body = body;
mm.IsBodyHtml = false;
SmtpClient smtp = new()
{
Host = ConfigurationManager.AppSettings["Host"],
Port = int.Parse(ConfigurationManager.AppSettings["Port"]),
EnableSsl = true,
UseDefaultCredentials = false,
Credentials = new NetworkCredential(ConfigurationManager.AppSettings["Username"], ConfigurationManager.AppSettings["Password"]),
};
Console.WriteLine("Sending email...");
smtp.Send(mm);
Console.WriteLine("Email sent.");
System.Threading.Thread.Sleep(3000);
}
}
}
modified 26-Aug-21 23:19pm.
|
|
|
|
|
Looks like the reply.Options isn't set. You will need to test for null , or use a null-conditional operator:
if (reply.Options != null)
{
Console.WriteLine("Time to live: {0}", reply.Options.Ttl);
Console.WriteLine("Don't fragment: {0}", reply.Options.DontFragment);
}
...
SendEmail($"{site} Up", $@"Ping {site}
IP Address: {reply.Address}
RoundTrip time: {reply.RoundtripTime}
Time to live: {reply.Options?.Ttl}
Don't fragment: {reply.Options?.DontFragment}
Buffer size: {reply.Buffer?.Length}");
samflex wrote: For instance, none of these worked:
https://gis.massdot.state.ma.us/arcgis/rest
gis.massdot.state.ma.us/arcgis/rest/
gis.massdot.state.ma.us/arcgis/rest
You're pinging a server, not a URL. It looks like gis.massdot.state.ma.us either isn't up, or is blocking pings.
If you actually want to test a URL, you'd need to use a different approach. For example:
static async Task<int> Main(string[] args)
{
System.Collections.Concurrent.ConcurrentDictionary<string, string> urlToStatus = new();
IEnumerable<Task<bool>> tasks = args.Select(async url =>
{
bool result = await ServerStatusByAsync(url);
urlToStatus.TryAdd(url, result ? "UP" : "DOWN");
});
await Task.WhenAll(tasks);
StringBuilder body = new("Please find the status of the servers below:");
foreach (var kvp in urlToStatus)
{
body.AppendLine();
body.AppendFormat("{0}: {1}", kvp.Key, kvp.Value);
}
await SendEmailAsync("Server Status", body.ToString());
await Task.Delay(3000);
}
static async Task<bool> ServerStatusByAsync(string url)
{
HttpClient http = new();
using (HttpResponseMessage response = await http.GetAsync(url))
{
Console.WriteLine("GET {0}: {1}", url, response.StatusCode);
if (response.IsSuccessStatusCode)
{
await SendEmailAsync($"{url} WORKING", $"GET {url} returned {response.StatusCode}");
return true;
}
await SendEmailAsync($"{url} DOWN", $"GET {url} returned {response.StatusCode}");
return false;
}
}
static async Task SendEmailAsync(string subject, string body)
{
using MailMessage mm = new(ConfigurationManager.AppSettings["FromEmail"], "joeblow@yahoo.com");
mm.To.Add("johndoe@gmail.com");
mm.CC.Add("joesixpack@yahoo.com");
mm.Subject = subject;
mm.Body = body;
mm.IsBodyHtml = false;
SmtpClient smtp = new()
{
Host = ConfigurationManager.AppSettings["Host"],
Port = int.Parse(ConfigurationManager.AppSettings["Port"]),
EnableSsl = true,
UseDefaultCredentials = false,
Credentials = new NetworkCredential(ConfigurationManager.AppSettings["Username"], ConfigurationManager.AppSettings["Password"]),
};
await smtp.SendMailAsync(mm);
} This has the added advantage of testing all URLs at once, rather than one-by-one, which should reduce the time it takes to test multiple URLs.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
My goodness, how did you learn all of these?
WOW.
Just a couple of things sir,
One, I got this error:
Error CS0161 'Program.Main(string[])': not all code paths return a value
I am assuming that all I needed to do was copy your latest code and replace from Main all the way down.
Second, runing it is still the same?
That is, showserverstatus.exe google.com yahoo.com gis..../rest/, etc?
I am truly in awe and so sorry for continuing to ask questions about this.
|
|
|
|
|
Sorry, missed the return statement:
static async Task<int> Main(string[] args)
{
System.Collections.Concurrent.ConcurrentDictionary<string, string> urlToStatus = new();
IEnumerable<Task<bool>> tasks = args.Select(async url =>
{
bool result = await ServerStatusByAsync(url);
urlToStatus.TryAdd(url, result ? "UP" : "DOWN");
});
bool[] results = await Task.WhenAll(tasks);
StringBuilder body = new("Please find the status of the servers below:");
foreach (var kvp in urlToStatus)
{
body.AppendLine();
body.AppendFormat("{0}: {1}", kvp.Key, kvp.Value);
}
await SendEmailAsync("Server Status", body.ToString());
await Task.Delay(3000);
return results.Count(result => !result);
}
Running it is still the same, except you now need to pass a list of URLs to test, rather than a list of server names to ping.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Oh man!
Getting the following error:
Unhandled exception. System.InvalidCastException: Unable to cast object of type 'SelectArrayIterator`2[System.String,System.Threading.Tasks.Task]' to type 'System.Collections.Generic.IEnumerable`1[System.Threading.Tasks.Task`1[System.Boolean]]'.
It says line 21 which is this line:
IEnumerable> tasks = (IEnumerable>)args.Select(async url =>
This is the second line in Main().
Just for clarity sir, this is your version:
IEnumerable < Task<bool> > tasks = args.Select(async url =>
However, when I ran it, I got:
CS0266 Cannot implicitly convert type 'System.Collections.Generic.IEnumerable' to 'System.Collections.Generic.IEnumerable>'. An explicit conversion exists (are you missing a cast?)
When I selected the suggested explicit cast option, the error went away but then I got the other error during testing.
The error occurred when I tried passing one URL as an argument to test like:
showserverstatus.exe google.com
UPDATE: It's always something!!!
I got the error worked out; just took me awhile to figure out what was missing - return...
Now, email is not working. Not getting sent.
UPDATE: Once again, I panicked and didn't calm down to look for solutions.
Now, it is working. It turns out that I added myemail.com.net which obviously will make it hard to receive an email.
After correcting it, everything is fine now.
My Lord, it is impossible to express my most heartfelt gratitude for your patience, incredible ingenuity and most of all, you don't insult me.
Thank you very much sir, THANK YOU!!!
modified 27-Aug-21 14:29pm.
|
|
|
|
|
Hi everyone
We host CodeProject on dedicated servers in a very grown up (read: expensive) hosting centre that has all the bells and whistles. This is great, but for a friend who's asking about cheap ASP.NET hosting I'm kind of at a loss as to what to recommend.
What are your thought?
Requirements:
- Must be able to host ASP.NET Core / .NET 5
- Must include SQL Server, MySQL or postgres (at least 10Gb)
- Doesn't need much CPU
- Doesn't need much disk storage
- Needs fast internet
- Must be affordable ($10 a month or less)
I've (personally) used Winhost but I can't recommend then. They are easy to use, have everything in the above list except speed. Their bandwidth is pretty awful.
What are your thoughts?
cheers
Chris Maunder
|
|
|
|
|
I'll toss something into the basket here Chris.
Most developers went cloud or Azure, AWS Amazon and Google.
They even went cloud with CDN to call CSS, Fonts, etc.
I looked into pricing once, you can check off boxes for SQL server, MySQL, Cosmos, Mongo
Choose how much bandwidth you want, bandwidth on demand.
But it seems to really boil down to how you package your project and how little it's used. The average seems to be 7 to 13 cents a hour which is about $50.40 to $93.60 a month max. I'm not sure if the price represents active use of the container or app, and you don't pay when the container or app is idle.
Container pricing - where your container just floats in the system and gets served.
Pricing - Container Instances | Microsoft Azure
Traditional pricing including virtual machines
App Service Pricing | Microsoft Azure
But considering the price of electricity, service techs, support, cost of software licensing, and profit there is no way in 2021 can you do this for $10 a month in western democracies using that technology unless you have a friend that gives you a solid. I would try looking in places with cheap electricity and fast internet connections like Moldova, Romania, Ukraine, Southern Texas, Central China, Bulgaria, Montenegro, Croatia. I'm not kidding.
On the other hand, you can host a Wordpress, Joomla, PHP app for dirt cheap, as low as $1 a month I've seen anywhere in the world. It's the price of the technology, application packaging, electricity that plays a huge factor in price.
Haven't talk to you in a long time. I made lots of money in the last 18 months off being a rogue programmer and changing my business model and advertising. Finally bought a car after 18 years of doing this, picked up a really clean used CPO 2018 Porsche Macan GTS with all the power train toys and low miles. There's good money to be made in PHP, but not much help with it.
If it ain't broke don't fix it
Discover my world at jkirkerx.com
|
|
|
|
|
Nice work on the car! That's awesome.
Your comment about actual hours vs "month" hours is very valid, and for this app it will be run very rarely (to start with).
To put this in perspective I am currently using WinHost for about $8/month and it comes with Windows, .NET 5 support and SQL Server. It's everything I need. Except the ability to scale and it has terrible bandwidth.
There is a place in Germany that offers dedicated servers for about $30 a month (if I remember correctly). You get the bare metal and off you go. They have awesome bandwidth and service. But they are in Germany and with the world being the world, jurisdictions come into play and make life difficult.
It's crazy this is still a difficult decision to analyse
cheers
Chris Maunder
|
|
|
|
|
Yeh Chris,
But bare metal is not scalable nor very redundant. With these these new cloud services you can turn the knob up and down on bandwidth, how many CPU's, or how many nodes process your application. So If this is seasonal say a Xmas application that sells sausage and cheese, you can turn the dial to max on Black Friday and turn it back down in January. I think you can also filter out bots by country as well to reduce bandwidth. Or if you keep all the dials real low, you can slow everything down to keep your bill down at the same level. Compared to $30 a month for bare metal, I'd choose the latter.
Then you get into packaging your app at that .Net Core level, where you can put it in a container and just upload the whole container and off it goes. If it gets hacked you just replace the container with another copy. With Docker you can make a Linux container that serves up your .Net app and even include SQL Server for Linux, and anything else you need to run your app in a single container. This reduces your software licensing cost by going Linux versus choosing a Windows Server container. And Docker now supports the new container format as well, so it doesn't have to be a Docker container anymore. You can now even package or create a Kubernetes container that can spawn across a Kubernetes cluster that is scalable as well. You just set how many times max that you wish to scale out the app when busy and how many to idle back down to.
How you plan and package your app will have a huge effect on your hosting options and how much you end up paying for it. If you look at my website, it runs in a Linux Docker container using .Net Core support for Linux, with Linux MongoDB infused inside the container as well. This container has a builtin network to support protected communications between the app and MongoDB, and gets served up using Kestrel 2.0 (Http2 with builtin Certificate) that is infused as well. The container listens on a odd number port that is not port 80 or 443 to further secure the container. Finally, this container runs on a Dell Linux cluster of 3 servers that is configured for Kubernetes nodes on super fast SSD drives running Ubuntu Linux command line only. I didn't have the heart to toss out my hardware so I rebuilt it as a cloud service model to experiment with before I pay those high prices. Because of my final litigation with the BSA and Microsoft, we agreed upon me going open source from this point on.
I've been studying this technology for 4 years now, but have been rogue implementing it. After participating in 100's of programmer meetups, this is the consensus now of how to do it in Irvine CA. But very few people can actually do this scope of work.
Kind of strange that I'm sharing this with you, but I'm not sure what the scope of your friends project is, so it may have very simple requirements that your trying to keep at a very simple level yet use the latest versions of .Net 5 which is super cool. I know what you mean by Jurisdictions but sometimes you have to cross them or remain outside of them.
If it ain't broke don't fix it
Discover my world at jkirkerx.com
|
|
|
|
|
Chris,
Did you try looking at this DiscountASP.NET hosting plan details[^] ?
Not sure how about their current performance but once upon a time we had a few demos and prototypes hosted through them. At a $10 budget they seem to be having a few things to offer too.
|
|
|
|
|
Interestingly while debugging an issue with WinHost I found that they use DiscountASP.NETs servers, so either white labelling DiscountASP.NET or simply a rebranded business unit under DiscountASP.NET directly.
So I'd have to say a big no to them, unfortunately. Cheap, easy to use, great for demos and small things, absolutely. But painfully slow
cheers
Chris Maunder
|
|
|
|
|
smarterasp.net
Tried switching a few times but got greatly discouraged and reverted due to the complexity of the software used to perform hosting related tasks. Plesk I think it was called. All 3 alternatives used it.
Their support is pretty decent too.
|
|
|
|
|
dear team can you help me on this
|
|
|
|
|
good day, am in the process of deploying an application on azure. the app was build on ASP.NET CORE with ANGULAR 2. But when i finished the deployment process it shows that all succeeded -and when it load the URL just saying "Loading..." nothing comes up, then when inspect the page i get the following error "ailed to load resource: the server responded with a status of 404 (Not Found)" and error "Uncaught Reference Error: System is not defined at (index):18" can some one assist me what steps i can follow to resolve this matter? URL:https://[DELETED].net/ Thanks
modified 9-Jul-21 13:52pm.
|
|
|
|
|
Either something did not deploy all the way or your urls are not done properly such that when published they are not correct anymore.
You'll have to use your developer tools to figure out what is going on or what is missing.
|
|
|
|
|
|
|
Hi,
I would like to Upgrade the Publish page into latest version(Publish Web) in Visual Studio 2012. I still have the older page to publish my Application. How do i upgrade this. Please let me know.
modified 4-Jul-21 7:05am.
|
|
|
|
|
The version of the "publish" page is linked to the version of Visual Studio. If you want the newer page, you need to upgrade Visual Studio.
VS2019 community edition is free, so there's no reason to continue using such an ancient version:
Visual Studio Community 2019 - Free IDE and Developer Tools[^]
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Hi All I am new to MVC and EntityFramework and am having a problem getting my form to save changes back to the database.
I have the following model
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations.Schema;
using System.Data.Services.Providers;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace HAZID.Core.Models
{
public class HAZID_Forms : HAZID_Base_Entity
{
[Display(Name = "HAZID_Workers_Id", ResourceType = typeof(Resources.Resource))]
[Required(ErrorMessageResourceName = "HAZID_Workers_Id_Error_Msg", ErrorMessageResourceType = typeof(Resources.Resource))]
public int HAZID_Workers_Id { get; set; }
[Display(Name = "HAZID_Supervisors_Id", ResourceType = typeof(Resources.Resource))]
[Required(ErrorMessageResourceName = "HAZID_Supervisor_Id_Error_Msg", ErrorMessageResourceType = typeof(Resources.Resource))]
public int HAZID_Supervisors_Id { get; set; }
[Display(Name = "HAZID_Form_DateTime", ResourceType = typeof(Resources.Resource))]
public DateTime HAZID_Form_DateTime { get; set; }
[Display(Name = "HAZID_District_Id", ResourceType = typeof(Resources.Resource))]
[Required(ErrorMessageResourceName = "HAZID_District_Id_Error_Msg", ErrorMessageResourceType = typeof(Resources.Resource))]
public int HAZID_District_Id { get; set; }
[Display(Name = "HAZID_Hazard_Location", ResourceType = typeof(Resources.Resource))]
[DataType(DataType.MultilineText)]
[Required(ErrorMessageResourceName = "HAZID_Hazard_Location_Error_Msg", ErrorMessageResourceType = typeof(Resources.Resource))]
public string HAZID_Hazard_Location { get; set; }
[Display(Name = "HAZID_Hazard_Description", ResourceType = typeof(Resources.Resource))]
[DataType(DataType.MultilineText)]
[Required(ErrorMessageResourceName = "HAZID_Hazard_Description_Error_Msg", ErrorMessageResourceType = typeof(Resources.Resource))]
public string HAZID_Hazard_Description { get; set; }
public string HAZID_Hazard_Description_Short { get { return HAZID_Hazard_Description.ToString().SubStringTo(30); } }
[Display(Name = "HAZID_Workers_Suggstion", ResourceType = typeof(Resources.Resource))]
[DataType(DataType.MultilineText)]
public string HAZID_Workers_Suggstion { get; set; }
public string HAZID_Workers_Suggstion_Short { get { return HAZID_Workers_Suggstion.ToString().SubStringTo(30); } }
[Display(Name = "HAZID_Position", ResourceType = typeof(Resources.Resource))]
public string HAZID_Position { get; set; }
[Display(Name = "HAZID_Status_Id", ResourceType = typeof(Resources.Resource))]
public int? HAZID_Status_Id { get; set; }
[Display(Name = "HAZID_Hazard_Type_Id", ResourceType = typeof(Resources.Resource))]
public int? HAZID_Hazard_Type_Id { get; set; }
[Display(Name = "HAZID_Control_Description", ResourceType = typeof(Resources.Resource))]
[DataType(DataType.MultilineText)]
public string HAZID_Control_Description { get; set; }
[Display(Name = "HAZID_Person_Responsible_Name", ResourceType = typeof(Resources.Resource))]
public string HAZID_Person_Responsible_Name { get; set; }
[Display(Name = "HAZID_Applcability_To_Others_Flag", ResourceType = typeof(Resources.Resource))]
public bool HAZID_Applcability_To_Others_Flag { get; set; }
[Display(Name = "HAZID_Risk_Severity_Id", ResourceType = typeof(Resources.Resource))]
public int? HAZID_Risk_Severity_Id { get; set; }
[Display(Name = "HAZID_Risk_Probability_Id", ResourceType = typeof(Resources.Resource))]
public int? HAZID_Risk_Probability_Id { get; set; }
[Display(Name = "HAZID_Action_Taken", ResourceType = typeof(Resources.Resource))]
[DataType(DataType.MultilineText)]
public string HAZID_Action_Taken { get; set; }
}
}
Two ViewModels
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using HAZID.Core.Models;
namespace HAZID.Core.ViewModels
{
public class HAZID_Form_View_Model
{
public HAZID_Forms HAZID_Form { get; set; }
public IEnumerable<HAZID_Branch_Districts> HAZID_Branch_Districts { get; set; }
public IEnumerable<HAZID_Persons> HAZID_Persons { get; set; }
public IEnumerable<HAZID_Hazard_Types> HAZID_Hazard_Types { get; set; }
public IEnumerable<HAZID_Risk_Severity_Types> HAZID_Risk_Severity_Types { get; set; }
public IEnumerable<HAZID_Risk_Probability_Types> HAZID_Risk_Probability_Types { get; set; }
public IEnumerable<HAZID_Statuses> HAZID_Statuses { get; set; }
}
}
<pre>using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using HAZID.Core.Models;
namespace HAZID.Core.ViewModels
{
public class HAZID_Forms_View_Model
{
public IEnumerable<HAZID_Forms> HAZID_Forms { get; set; }
public IEnumerable<HAZID_Branch_Districts> HAZID_Branch_Districts { get; set; }
public IEnumerable<HAZID_Hazard_Types> HAZID_Hazard_Types { get; set; }
public IEnumerable<HAZID_Risk_Severity_Types> HAZID_Risk_Severity_Types { get; set; }
public IEnumerable<HAZID_Risk_Probability_Types> HAZID_Risk_Probability_Types { get; set; }
public IEnumerable<HAZID_Statuses> HAZID_Statuses { get; set; }
public IEnumerable<HAZID_Persons> HAZID_Persons { get; set; }
}
}
The Controller looks like this
using HAZID.Core.Contracts;
using HAZID.Core.Models;
using HAZID.Core.ViewModels;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.Mvc;
namespace HAZID.WebUI.Controllers
{
public class HAZID_ApplicationController : Controller
{
IHAZID_Repository<HAZID_Forms> hazidForms;
IHAZID_Repository<HAZID_Branch_Districts> hazidBranchDistricts;
IHAZID_Repository<HAZID_Hazard_Types> hazidHazardTypes;
IHAZID_Repository<HAZID_Risk_Severity_Types> hazidRiskSeverityTypes;
IHAZID_Repository<HAZID_Risk_Probability_Types> hazidRiskProbabilityTypes;
IHAZID_Repository<HAZID_Statuses> hazidStatuses;
IHAZID_Repository<HAZID_Persons> hazidPersons;
public HAZID_ApplicationController(IHAZID_Repository<HAZID_Forms> hazidFormContext, IHAZID_Repository<HAZID_Branch_Districts> hazidBranchDistrictContext,
IHAZID_Repository<HAZID_Hazard_Types> hazidHazardTypeContext, IHAZID_Repository<HAZID_Risk_Severity_Types> hazidRiskSeverityTypeContext,
IHAZID_Repository<HAZID_Risk_Probability_Types> hazidRiskProbabilityTypeContext, IHAZID_Repository<HAZID_Statuses> hazidStatusContext,
IHAZID_Repository<HAZID_Persons> hazidPersonContext)
{
this.hazidForms = hazidFormContext;
this.hazidBranchDistricts = hazidBranchDistrictContext;
this.hazidHazardTypes = hazidHazardTypeContext;
this.hazidRiskSeverityTypes = hazidRiskSeverityTypeContext;
this.hazidRiskProbabilityTypes = hazidRiskProbabilityTypeContext;
this.hazidStatuses = hazidStatusContext;
this.hazidPersons = hazidPersonContext;
}
public ActionResult ListReports()
{
HAZID_Forms_View_Model hazidFormsViewModel = new HAZID_Forms_View_Model();
hazidFormsViewModel.HAZID_Forms = hazidForms.Collection().ToList();
hazidFormsViewModel.HAZID_Branch_Districts = hazidBranchDistricts.Collection();
hazidFormsViewModel.HAZID_Hazard_Types = hazidHazardTypes.Collection();
hazidFormsViewModel.HAZID_Risk_Severity_Types = hazidRiskSeverityTypes.Collection();
hazidFormsViewModel.HAZID_Risk_Probability_Types = hazidRiskProbabilityTypes.Collection();
hazidFormsViewModel.HAZID_Statuses = hazidStatuses.Collection();
hazidFormsViewModel.HAZID_Persons = hazidPersons.Collection();
return View(hazidFormsViewModel);
}
public ActionResult EditReport(int id)
{
HAZID_Forms hazidFormToEdit = hazidForms.Find(id);
if (hazidFormToEdit == null)
{
return HttpNotFound();
}
else
{
HAZID_Form_View_Model hazidFormViewModel = new HAZID_Form_View_Model();
hazidFormViewModel.HAZID_Form = hazidFormToEdit;
hazidFormViewModel.HAZID_Branch_Districts = hazidBranchDistricts.Collection();
hazidFormViewModel.HAZID_Hazard_Types = hazidHazardTypes.Collection();
hazidFormViewModel.HAZID_Risk_Severity_Types = hazidRiskSeverityTypes.Collection();
hazidFormViewModel.HAZID_Risk_Probability_Types = hazidRiskProbabilityTypes.Collection();
hazidFormViewModel.HAZID_Statuses = hazidStatuses.Collection();
hazidFormViewModel.HAZID_Persons = hazidPersons.Collection();
return View(hazidFormViewModel);
}
}
[HttpPost]
public ActionResult EditReport(HAZID_Form_View_Model hazidFormViewModel, int id)
{
HAZID_Forms hazidFormToEdit = hazidForms.Find(id);
if (hazidFormToEdit == null)
{
return HttpNotFound();
}
else
{
if (!ModelState.IsValid)
{
return View(hazidFormViewModel);
}
hazidFormToEdit = hazidFormViewModel.HAZID_Form;
hazidForms.Commit();
return RedirectToAction("ListReports");
}
}
public ActionResult ViewForm(int id)
{
HAZID_Forms hazidFormToView = hazidForms.Find(id);
if (hazidFormToView == null)
{
return HttpNotFound();
}
else
{
HAZID_Form_View_Model hazidFormViewModel = new HAZID_Form_View_Model();
hazidFormViewModel.HAZID_Form = hazidFormToView;
hazidFormViewModel.HAZID_Branch_Districts = hazidBranchDistricts.Collection();
hazidFormViewModel.HAZID_Hazard_Types = hazidHazardTypes.Collection();
hazidFormViewModel.HAZID_Risk_Severity_Types = hazidRiskSeverityTypes.Collection();
hazidFormViewModel.HAZID_Risk_Probability_Types = hazidRiskProbabilityTypes.Collection();
hazidFormViewModel.HAZID_Statuses = hazidStatuses.Collection();
hazidFormViewModel.HAZID_Persons = hazidPersons.Collection();
return View(hazidFormViewModel);
}
}
}
}
My Edit view looks like this
@model HAZID.Core.ViewModels.HAZID_Form_View_Model
@{
ViewBag.Title = "Edit Report";
}
@using (Html.BeginForm())
{
@Html.AntiForgeryToken()
<div class="form-horizontal">
<h4>HASS Report Details</h4>
<hr />
@Html.ValidationSummary(true, "", new { @class = "text-danger" })
@Html.HiddenFor(model => model.HAZID_Form.Id)
@Html.HiddenFor(model => model.HAZID_Form.HAZID_Workers_Id)
@Html.HiddenFor(model => model.HAZID_Form.HAZID_Form_DateTime)
@Html.HiddenFor(model => model.HAZID_Form.HAZID_District_Id)
@Html.HiddenFor(model => model.HAZID_Form.HAZID_Supervisors_Id)
@Html.HiddenFor(model => model.HAZID_Form.HAZID_Hazard_Location)
@Html.HiddenFor(model => model.HAZID_Form.HAZID_Hazard_Description)
@Html.HiddenFor(model => model.HAZID_Form.HAZID_Workers_Suggstion)
<div class="form-group col-md-10">
<div class="row">
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_Workers_Id)
</div>
<div class="col-7">
@Html.Raw(Model.HAZID_Persons.FirstOrDefault(c => c.Id == Model.HAZID_Form.HAZID_Workers_Id).Full_Name)
</div>
</div>
<div class="row">
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_Position)
</div>
<div class="col-7">
@Html.Raw(Model.HAZID_Form.HAZID_Position)
</div>
</div>
<div class="row">
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_Form_DateTime)
</div>
<div class="col-7">
@Html.Raw(Model.HAZID_Form.HAZID_Form_DateTime.ToString())
</div>
</div>
<div class="row">
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_Supervisors_Id)
</div>
<div class="col-7">
@Html.Raw(Model.HAZID_Persons.FirstOrDefault(c => c.Id == Model.HAZID_Form.HAZID_Supervisors_Id).Full_Name)
</div>
</div>
<div class="row">
@{
var hazidDistrictName = string.Empty;
if (System.Threading.Thread.CurrentThread.CurrentUICulture.Name == "en")
{
hazidDistrictName = Model.HAZID_Branch_Districts.FirstOrDefault(c => c.Id == Model.HAZID_Form.HAZID_District_Id).English_Description.ToString();
}
else
{
hazidDistrictName = Model.HAZID_Branch_Districts.FirstOrDefault(c => c.Id == Model.HAZID_Form.HAZID_District_Id).French_Description.ToString();
}
}
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_District_Id)
</div>
<div class="col-7">
@Html.Raw(hazidDistrictName)
</div>
</div>
<div class="row">
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_Hazard_Location)
</div>
<div class="col-7">
@Html.Raw(Model.HAZID_Form.HAZID_Hazard_Location)
</div>
</div>
<div class="row">
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_Hazard_Description)
</div>
<div class="col-7">
@Html.Raw(Model.HAZID_Form.HAZID_Hazard_Description)
</div>
</div>
<div class="row">
<div class="col-3">
@Html.CustomLabelFor(model => model.HAZID_Form.HAZID_Workers_Suggstion)
</div>
<div class="col-7">
@Html.Raw(Model.HAZID_Form.HAZID_Workers_Suggstion)
</div>
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Status_Id, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-3">
@Html.DropDownListFor(model => model.HAZID_Form.HAZID_Status_Id, new SelectList(Model.HAZID_Statuses, "Id", Resources.Resource.HAZID_Column_Select), Resources.Resource.HAZID_Status_Id_Select, new { htmlAttributes = new { @class = "form-control", id = "HAZID_Form_HAZID_Status_Id" } })
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Action_Taken, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-10">
@Html.EditorFor(model => model.HAZID_Form.HAZID_Action_Taken, new { htmlAttributes = new { @class = "form-control", @style = "width:100% !important; min-width:600px; height:100px" } })
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Hazard_Type_Id, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-4">
@Html.DropDownListFor(model => model.HAZID_Form.HAZID_Hazard_Type_Id, new SelectList(Model.HAZID_Hazard_Types, "Id", Resources.Resource.HAZID_Column_Select), Resources.Resource.HAZID_Hazard_Type_Select, new { htmlAttributes = new { @class = "form-control", id = "HAZID_Form_HAZID_Hazard_Type_Id" } })
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Risk_Severity_Id, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-4">
@Html.DropDownListFor(model => model.HAZID_Form.HAZID_Risk_Severity_Id, new SelectList(Model.HAZID_Risk_Severity_Types, "Id", Resources.Resource.HAZID_Column_Select), Resources.Resource.HAZID_Risk_Severity_Id_Select, new { htmlAttributes = new { @class = "form-control", id = "HAZID_Form_HAZID_Risk_Severity_Id" } })
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Hazard_Type_Id, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-4">
@Html.DropDownListFor(model => model.HAZID_Form.HAZID_Risk_Probability_Id, new SelectList(Model.HAZID_Risk_Probability_Types, "Id", Resources.Resource.HAZID_Column_Select), Resources.Resource.HAZID_Risk_Probability_Id_Select, new { htmlAttributes = new { @class = "form-control", id = "HAZID_Form_HAZID_Risk_Probability_Id" } })
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Control_Description, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-4">
@Html.EditorFor(model => model.HAZID_Form.HAZID_Control_Description, new { htmlAttributes = new { @class = "form-control", @style = "width:100% !important; min-width:600px; height:100px" } })
@Html.ValidationMessageFor(model => model.HAZID_Form.HAZID_Control_Description, "", new { @class = "text-danger" })
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Person_Responsible_Name, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-10">
@Html.EditorFor(model => model.HAZID_Form.HAZID_Person_Responsible_Name, new { htmlAttributes = new { @class = "form-control" } })
@Html.ValidationMessageFor(model => model.HAZID_Form.HAZID_Person_Responsible_Name, "", new { @class = "text-danger" })
</div>
</div>
<div class="form-group">
@Html.LabelFor(model => model.HAZID_Form.HAZID_Applcability_To_Others_Flag, htmlAttributes: new { @class = "control-label col-md-2" })
<div class="col-md-10">
@Html.CheckBoxFor(model => model.HAZID_Form.HAZID_Applcability_To_Others_Flag)
</div>
</div>
<div class="form-group">
<div class="col-md-offset-2 col-md-10">
<input type="submit" value="Save" class="btn btn-outline-primary" />
</div>
</div>
</div>
}
<div>
@Html.ActionLink("Back to List", "ListReports")
</div>
@section Scripts {
@Scripts.Render("~/bundles/jqueryval")
<script type="text/javascript">
$(function () {
$("#HAZID_Form_HAZID_Status_Id").select2();
$("#HAZID_Form_HAZID_Hazard_Type_Id").select2();
$("#HAZID_Form_HAZID_Risk_Severity_Id").select2();
$("#HAZID_Form_HAZID_Risk_Probability_Id").select2();
$('.select2-container').css("width", "100%");
});
</script>
}
My problem is when I click the save the data is there but after the commit and redirect the data was not saved to the database.
if someone can help me it would be very much appreciated.
|
|
|
|
|
Member 15016778 wrote:
HAZID_Forms hazidFormToEdit = hazidForms.Find(id);
...
hazidFormToEdit = hazidFormViewModel.HAZID_Form;
hazidForms.Commit(); Your code finds the form with the specified ID, and stores it in a local variable.
It then overwrites the local variable with the value from the view-model, breaking any link between the variable and the repository.
It then tells the repository to commit the changes. But there are no changes to commit, because you've not updated anything that the repository knows about.
Instead of overwriting the local variable, you need to update the entity returned from the Find method using the properties of the view-model.
You'll also need to repopulate the view-model collections before displaying the view again.
private void PopulateLookups(HAZID_Form_View_Model hazidFormViewModel)
{
hazidFormViewModel.HAZID_Branch_Districts = hazidBranchDistricts.Collection();
hazidFormViewModel.HAZID_Hazard_Types = hazidHazardTypes.Collection();
hazidFormViewModel.HAZID_Risk_Severity_Types = hazidRiskSeverityTypes.Collection();
hazidFormViewModel.HAZID_Risk_Probability_Types = hazidRiskProbabilityTypes.Collection();
hazidFormViewModel.HAZID_Statuses = hazidStatuses.Collection();
hazidFormViewModel.HAZID_Persons = hazidPersons.Collection();
}
[HttpGet]
public ActionResult EditReport(int id)
{
HAZID_Forms hazidFormToEdit = hazidForms.Find(id);
if (hazidFormToEdit == null)
{
return HttpNotFound();
}
HAZID_Form_View_Model hazidFormViewModel = new HAZID_Form_View_Model();
hazidFormViewModel.HAZID_Form = hazidFormToEdit;
PopulateLookups(hazidFormViewModel);
return View(hazidFormViewModel);
}
[HttpPost]
[ValidateAntiForgeryToken]
public ActionResult EditReport(HAZID_Form_View_Model hazidFormViewModel, int id)
{
HAZID_Forms hazidFormToEdit = hazidForms.Find(id);
if (hazidFormToEdit == null)
{
return HttpNotFound();
}
if (!ModelState.IsValid)
{
PopulateLookups(hazidFormViewModel);
return View(hazidFormViewModel);
}
hazidFormToEdit.HAZID_Status_Id = hazidFormViewModel.HAZID_Form.HAZID_Status_Id;
hazidFormToEdit.HAZID_Action_Taken = hazidFormViewModel.HAZID_Form.HAZID_Action_Taken;
...
hazidForms.Commit();
return RedirectToAction("ListReports");
}
NB: Don't use @Html.Raw(...) when displaying values in your view unless you expect the property to contain valid HTML which you want to include in your output. As it stands, your code is vulnerable to a persisted cross-site scripting (XSS) attack[^].
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|