trouble with basic coding, new to c++

Question

4.00/5 (1 vote)

See more:

I am new to C++. Im trying to get this program to run properly. i cannot, for the life of me, find my mistake. I'm sure it will be obvious to many.

it compiles, but when it runs it just goes straight to a system pause.

#include <iostream>
using namespace std;


void description();
double getDataz();
int printDataz(double salesAmount, double commissionRate, double totalBonus);

int main()
{
     cout << "main entered";
     description();
     cout << "description called";
     double salesAmount, commissionRate, totalBonus = getDataz();
     cout << "getdataz called";
     printDataz(salesAmount, commissionRate, totalBonus);
     cout << "printdataz called";
     return 0;
}

void description()
{
     cout << "This program will calculate the commission rate and total bonus "
          << "for an associate's sales";
     return;
}

double getDataz()
{
       double salesAmount;
       double commissionRate;
       double totalBonus;
       
       
       
       cout << "\n\n\nPlease enter the sales amount:";
       cin  >> salesAmount;
       
       if      (salesAmount < 20000) commissionRate = .04;
       else if  (salesAmount >= 20000 && salesAmount < 30000) commissionRate = .05;
       else if  (salesAmount >= 30000 && salesAmount < 40000) commissionRate = .06;
       else if  (salesAmount >= 40000 && salesAmount < 50000) commissionRate = .07;
       else if  (salesAmount >= 50000) commissionRate = .09;
       
       totalBonus = salesAmount * commissionRate;
       
       return salesAmount, commissionRate, totalBonus;
}
       
int printDataz(double salesAmount, double commissionRate, double totalBonus)
{
     cout << "\n\nThe commission rate for $"<<salesAmount<<" is: " << commissionRate<<endl;
     cout << "The total bonus is: $"<<totalBonus;
     system("pause");
     return 0;
}

[modified] Removed "help me!!" in 2 locations. [\modified]

thanks!!

Posted 3-Mar-11 7:29am

hhays

Updated 3-Mar-11 7:58am

wizardzz

v2

Add a Solution

2 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2011-03-03T07:52:00

hhaysMr_Gbg wrote:
return salesAmount, commissionRate, totalBonus;

You cannot return 3 values from a C++ function (only a value is allowed).
Code compiles because the comma operator discards all the values but the last.

A simple solution would be passing the three parameters by reference:

C++

void getDataz(double & salesAmount, double & commissionRate, double & totalBonus)
{
      cout << "\n\n\nPlease enter the sales amount:";
       cin  >> salesAmount;
       
       if      (salesAmount < 20000) commissionRate = .04;
       else if  (salesAmount >= 20000 && salesAmount < 30000) commissionRate = .05;
       else if  (salesAmount >= 30000 && salesAmount < 40000) commissionRate = .06;
       else if  (salesAmount >= 40000 && salesAmount < 50000) commissionRate = .07;
       else if  (salesAmount >= 50000) commissionRate = .09;
       
       totalBonus = salesAmount * commissionRate;
}

[update]
This program

C++

#include <iostream>
using namespace std;


void description();
void getDataz(double & salesAmount, double & commissionRate, double & totalBonus);
int printDataz(double salesAmount, double commissionRate, double totalBonus);

int main()
{
    double salesAmount, commissionRate, totalBonus;
     cout << "main entered";
     description();
     cout << "description called";
      getDataz(salesAmount, commissionRate, totalBonus);
     cout << "getdataz called";
     printDataz(salesAmount, commissionRate, totalBonus);
     cout << "printdataz called";
     return 0;
}

void description()
{
     cout << "This program will calculate the commission rate and total bonus "
          << "for an associate's sales";
     return;
}

void getDataz(double & salesAmount, double & commissionRate, double & totalBonus)
{
  /*
       double salesAmount;
       double commissionRate;
       double totalBonus;
    */


       cout << "\n\n\nPlease enter the sales amount:";
       cin  >> salesAmount;

       if      (salesAmount < 20000) commissionRate = .04;
       else if  (salesAmount >= 20000 && salesAmount < 30000) commissionRate = .05;
       else if  (salesAmount >= 30000 && salesAmount < 40000) commissionRate = .06;
       else if  (salesAmount >= 40000 && salesAmount < 50000) commissionRate = .07;
       else if  (salesAmount >= 50000) commissionRate = .09;

       totalBonus = salesAmount * commissionRate;

    //   return salesAmount, commissionRate, totalBonus;
}

int printDataz(double salesAmount, double commissionRate, double totalBonus)
{
     cout << "\n\nThe commission rate for $"<<salesAmount<<" is: " << commissionRate<<endl;
     cout << "The total bonus is: $"<<totalBonus;
     system("pause");
     return 0;
}

produces the following, on my system (Windows 7, Visual Studio 2010):

main enteredThis program will calculate the commission rate and total bonus for
an associate's salesdescription called

Please enter the sales amount:100
getdataz called

The commission rate for $100 is: 0.04
The total bonus is: $4Press any key to continue . . .

[/update]

:)

aash 2 · Answer 2 · 2011-03-03T20:38:00

Solution 2

ok, now first thing is to write include files.

[code]
#include <iostream> //this file includes I/O operations
using namespace std; //using directive to allow I/O operations
[/code]

And void function doesn't return anything, so don't use return in your void functions.

regards,
aash

Posted 3-Mar-11 20:38pm

aash 2

Updated 3-Mar-11 20:41pm

v3

trouble with basic coding, new to c++

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

trouble with basic coding, new to c++

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us